After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669098 - saved-im-presence and saved-session-presence don't have a summary
saved-im-presence and saved-session-presence don't have a summary
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-31 10:10 UTC by Guillaume Desmottes
Modified: 2012-02-20 07:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
set a summary on the saved-im-presence and saved-session-presence keys (1.14 KB, patch)
2012-01-31 10:11 UTC, Guillaume Desmottes 		needs-work Details | Review
set a summary on the saved-im-presence and saved-session-presence keys (1.31 KB, patch)
2012-02-17 08:11 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-01-31 10:10:49 UTC 
These gsettings keys don't have a summary making gnome-tweak-tool cry at startup:

WARNING : Schema /home/cassidy/usr/share/glib-2.0/schemas/org.gnome.shell.gschema.xml missing summary text: <key name="saved-im-presence" type="i">
      <default>1</default>
      <summary/>
    </key>
WARNING : Schema /home/cassidy/usr/share/glib-2.0/schemas/org.gnome.shell.gschema.xml missing summary text: <key name="saved-session-presence" type="i">
      <default>0</default>
      <summary/>
    </key>
Comment 1 Guillaume Desmottes 2012-01-31 10:11:39 UTC 
Created attachment 206504 [details] [review]
set a summary on the saved-im-presence and saved-session-presence keys
Comment 2 Owen Taylor 2012-02-16 16:12:45 UTC 
Review of attachment 206504 [details] [review]:

This is sort of bound up with bug 668214, but i think we can go ahead and land something here anyways

::: data/org.gnome.shell.gschema.xml.in
@@ +54,3 @@
     <key name="saved-im-presence" type="i">
       <default>1</default>
+      <_summary>The last TpConnectionPresenceType set on IM accounts</_summary>

i think a better summary would be something like;

 Internally used to store the last IM presence explicitly set by the user. The value here is from the TpConnectionPresenceType enumeration.

With the biggest change being simply the use of the word 'Internal"

@@ +58,3 @@
     <key name="saved-session-presence" type="i">
       <default>0</default>
+      <_summary>The last GsmPresenceStatus set on the session</_summary>

Maybe:

 Internally used to store the last session presence status for the user. TThe value here is from the GsmPresenceStatus enumeration.
Comment 3 Guillaume Desmottes 2012-02-17 08:11:32 UTC 
Created attachment 207836 [details] [review]
set a summary on the saved-im-presence and saved-session-presence keys
Comment 4 Owen Taylor 2012-02-17 14:56:34 UTC 
Review of attachment 207836 [details] [review]:

Thanks
Comment 5 Guillaume Desmottes 2012-02-20 07:42:37 UTC 
Attachment 207836 [details] pushed as 7a4b613 - set a summary on the saved-im-presence and saved-session-presence keys