After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668433 - --build-optional-modules has unknown impact
--build-optional-modules has unknown impact
Status: RESOLVED NOTABUG
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on: 668434
Blocks:
 
 
Reported: 2012-01-22 12:23 UTC by Craig Keogh
Modified: 2012-04-15 22:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove --build-optional-modules as it doesn't work (4.77 KB, patch)
2012-01-22 12:46 UTC, Craig Keogh
none Details | Review

Description Craig Keogh 2012-01-22 12:23:58 UTC
The --build-optional-modules doesn't seem to have any impact.
Comment 1 Craig Keogh 2012-01-22 12:46:33 UTC
Created attachment 205810 [details] [review]
Remove --build-optional-modules as it doesn't work

Attachment 205809 [details] needs to be applied first before this patch.
Comment 2 Frederic Peters 2012-02-07 10:09:00 UTC
It does have some effect; but as it operates on <after> modules, and we don't have that many of them in the gnome modulesets, its effect is quite limited. Changing some <suggests> to <after> in gnome-apps-3.4 (in gupnp-dlna), I get the following proof:

$ jhbuild -m gnome-apps-3.4 list --list-optional-modules | wc -l
214
$ jhbuild -m gnome-world-3.4 list | wc -l
216
$ jhbuild -m gnome-world-3.4 list --list-optional-modules | wc -l
219
Comment 3 Craig Keogh 2012-02-07 11:35:29 UTC
Ok, it has *some* effect, but what effect?

I added font-config as a fictitious after dep of glib.

# jhbuild list glib
gnome-common
intltool
gnome-doc-utils
gtk-doc
glib

# jhbuild list glib --list-optional-modules
gnome-common
intltool
gnome-doc-utils
gtk-doc
glib
Comment 4 Frederic Peters 2012-02-07 11:59:23 UTC
Works for me (using fontconfig, not font-config):

gnome-common
intltool
rarian
gnome-doc-utils
gtk-doc
expat
fontconfig
glib

Other tests regarding glib could fail on the dependency circle handling (this is why shared-mime-info is not mentioned on jhbuild list glib --list-optional-modules)

For a simple example:

  <metamodule id="a">
    <after>
      <dep package="b"/>
    </after>
  </metamodule>

  <metamodule id="b">
  </metamodule>

Will build b then a, if optional modules are requested.
Comment 5 Craig Keogh 2012-04-15 22:53:30 UTC
Thanks Frédéric, I understand what is happening now. I've implemented what I've learnt in bug 669554.