Bug 668367 – GtkApplicationWindow dislikes GtkAction accelerator syntax

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 668367 - GtkApplicationWindow dislikes GtkAction accelerator syntax


Summary:	GtkApplicationWindow dislikes GtkAction accelerator syntax


Status:	RESOLVED FIXED

Product:	gtk+
Classification:	Platform
Component:	Widget: Other
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gtk-bugs
QA Contact:	gtk-bugs

URL:
Whiteboard:

Duplicates:	668511 (view as bug list)
Depends on:
Blocks:

Reported:	2012-01-20 18:54 UTC by Xan Lopez
Modified:	2012-01-23 16:17 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
GtkApplication: change the accel prefix we use (1.51 KB, patch) 2012-01-20 18:57 UTC, Allison Karlitskaya (desrt)	committed	Details \| Review

Description Xan Lopez 2012-01-20 18:54:49 UTC

Epiphany git master uses GtkApplicationWindow but still adds a GtkUIManager accel group to it. The result is this kind of warning for every single action with an accel:

Gtk-WARNING **: Failed to parse parameter from '<Actions>/WindowActions/TabsMoveRight'


Program received signal SIGTRAP, Trace/breakpoint trap.
0x00007ffff592b9c8 in g_logv (log_domain=0x7ffff660c5f5 "Gtk", log_level=G_LOG_LEVEL_WARNING, format=0x7ffff660c5d0 "Failed to parse parameter from '%s'\n", args1=0x7fffffffcdb8) at gmessages.c:758
758			G_BREAKPOINT ();
(gdb) bt

+ Trace 229483

#0 g_logv
at gmessages.c line 758
#1 g_log
at gmessages.c line 792
#2 add_accel_closure
at gtkapplicationwindow.c line 381
#3 gtk_accel_map_foreach
at gtkaccelmap.c line 838
#4 gtk_application_window_update_accels
at gtkapplicationwindow.c line 416
#5 gtk_application_window_real_realize
at gtkapplicationwindow.c line 691
#6 g_cclosure_marshal_VOID__VOID
at gmarshal.c line 85
#7 g_type_class_meta_marshal
at gclosure.c line 885
#8 g_closure_invoke
at gclosure.c line 774
#9 signal_emit_unlocked_R
at gsignal.c line 3232
#10 g_signal_emit_valist
at gsignal.c line 3033
#11 g_signal_emit
at gsignal.c line 3090
#12 gtk_widget_realize
at gtkwidget.c line 4410
#13 ephy_gui_window_update_user_time
at ../../lib/ephy-gui.c line 397
#14 ephy_shell_new_tab_full
at ../../src/ephy-shell.c line 801
#15 session_command_dispatch
at ../../src/ephy-session.c line 754
#16 g_idle_dispatch
at gmain.c line 4632
#17 g_main_dispatch
at gmain.c line 2513
#18 g_main_context_dispatch
at gmain.c line 3050
#19 g_main_context_iterate
at gmain.c line 3121
#20 g_main_context_iteration
at gmain.c line 3182
#21 g_application_run
at gapplication.c line 1496
#22 main
at ../../src/ephy-main.c line 472

Comment 1 Allison Karlitskaya (desrt) 2012-01-20 18:57:44 UTC

Created attachment 205723 [details] [review]
GtkApplication: change the accel prefix we use

GtkApplication adds to the global accel map using the prefix <Actions>
which is also used by GtkAction.  This causes GtkApplicationWindow to
try to parse GtkAction-added accels as if they were its own (which
fails).

Switch to a different namespace -- <GAction>/.

Comment 2 Matthias Clasen 2012-01-21 00:51:07 UTC

Review of attachment 205723 [details] [review]:

Yes, I think this is the right fix

Comment 3 Xan Lopez 2012-01-23 16:15:23 UTC

*** Bug 668511 has been marked as a duplicate of this bug. ***

Comment 4 Allison Karlitskaya (desrt) 2012-01-23 16:17:39 UTC

Attachment 205723 [details] pushed as 880daf8 - GtkApplication: change the accel prefix we use