GNOME Bugzilla – Bug 668361
Expose CHECKED state based on the pseudo_class
Last modified: 2012-02-29 15:46:51 UTC
In the same way that in the past (bug 636717) we started to use the pseudo_class "selected" to expose that a object was selected, we could do the same for the case of "checked" objects.
Created attachment 205715 [details] [review] Adds ATK_STATE_CHECKED if the widget is using "checked" style Just one comment: we could be more strict and just adding this state if the role of the object is the proper one (in other words, if the object is "checkable"). For example, we would only add ATK_STATE_CHECKED if the object role is ATK_ROLE_CHECK_MENU_ITEM or ATK_ROLE_CHECK_BUTTON. But I think that it is not required, and that we can assume that if someone wants to use the style "checked" is because makes sense to use that style.
Comment on attachment 205715 [details] [review] Adds ATK_STATE_CHECKED if the widget is using "checked" style >+ if (found != self->priv->checked) >+ { >+ self->priv->selected = found; "selected" should be "checked" otherwise looks right
(In reply to comment #2) > (From update of attachment 205715 [details] [review]) > >+ if (found != self->priv->checked) > >+ { > >+ self->priv->selected = found; > > "selected" should be "checked" > > otherwise looks right Fixed. Committed. Closing bug.