After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668355 - rtpsession: dead code in check_collision handling
rtpsession: dead code in check_collision handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-20 16:34 UTC by Mark Nauwelaerts
Modified: 2013-02-07 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Mark Nauwelaerts 2012-01-20 16:34:23 UTC 
There seems to be some possibly dead code in check_collision (following FIXME).

Not sure what has been the evolution here, and whether it is really dead, is acceptably so, or other parts should give it a chance.
Comment 1 Olivier Crête 2013-01-28 22:50:25 UTC 
Where do you see dead code exactly ?
Comment 2 Mark Nauwelaerts 2013-02-02 17:06:05 UTC 
See the large if statement before the FIXME comment in check_collision.
It looks like every possible branch there results in a return statement, so the code following the if is then never executed.

If course, I could be blatantly misreading.  If so, merely point out a branch/path that does make it through and this is INVALID (or so), otherwise there really is dead code.
Comment 3 Wim Taymans 2013-02-07 14:08:18 UTC 
commit 2971ed44eeef9d910333122c393b3ecb6e281916
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Thu Feb 7 15:06:40 2013 +0100

    rtpsession: remove dead code
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=668355