GNOME Bugzilla – Bug 668310
ephy-shell: don't use extensions in internal code
Last modified: 2012-01-29 06:52:03 UTC
This is an unsolved mystery I found while working in the libpeas migration. I'd rather commit it separately, so here it is. Basically, we are using EphyExtensions infra to attach lockdown and session recovery. This is overkill, a simple API is enough.
Created attachment 205666 [details] [review] ephy-shell: don't use extensions in internal code ephy-session and ephy-lockdown don't need to be EphyExtension objects to work properly. Just creating an attach/dettach API is enough for both. Simplify code by turning both to regular code.
Review of attachment 205666 [details] [review]: Now you have to make sure you properly track the objects in EphyWindow, which seems a bit pointless? Besides it's not like this is a huge simplification to be honest. I'd not apply this.
(In reply to comment #2) > Review of attachment 205666 [details] [review]: > > Now you have to make sure you properly track the objects in EphyWindow, which > seems a bit pointless? Besides it's not like this is a huge simplification to > be honest. I'd not apply this. Perhaps this makes more sense because of whatever you did in your branch. If so please elaborate, I'm open to reconsidering.
(In reply to comment #3) > (In reply to comment #2) > > Review of attachment 205666 [details] [review] [details]: > > > > Now you have to make sure you properly track the objects in EphyWindow, which > > seems a bit pointless? Besides it's not like this is a huge simplification to > > be honest. I'd not apply this. > > Perhaps this makes more sense because of whatever you did in your branch. If so > please elaborate, I'm open to reconsidering. I didn't see a reason for them to be extensions. I guess I can mimic this in peas.
(In reply to comment #4) > > I didn't see a reason for them to be extensions. I guess I can mimic this in > peas. That said, it might have been that I didn't find the way to do this with peas. Will check.
OK, yes. libpeas doesn't load GObjects like EphyExtensionsManager did. It only handles stuff it can find in the filesystem as loadable modules. So, I'd rather do something similar to this patch than fight libpeas. What do you meant by properly track objects in EphyWindow? We only care for window creation and destruction.
Marking duplicate of peas porting bug #646597 This is gonna happen as part of that, not individually. *** This bug has been marked as a duplicate of bug 646597 ***