After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668163 - GDBusConnection: note that exit-on-close is sometimes TRUE
GDBusConnection: note that exit-on-close is sometimes TRUE
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other All
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-01-18 10:22 UTC by Will Thompson
Modified: 2012-01-18 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GDBusConnection: note that exit-on-close is sometimes TRUE (1.22 KB, patch)
2012-01-18 10:22 UTC, Will Thompson 		committed Details | Review

Description Will Thompson 2012-01-18 10:22:23 UTC 
GDBusConnection:exit-on-close officially defaults to FALSE, but most API users will get objects with it set to TRUE. This should be mentioned in the property's documentation.
Comment 1 Will Thompson 2012-01-18 10:22:48 UTC 
Created attachment 205513 [details] [review]
GDBusConnection: note that exit-on-close is sometimes TRUE

g_bus_get_finish() and g_bus_get_sync() both document that the returned
object will usually have exit-on-close set to TRUE, but the property's
documentation specified that its default is FALSE. While that's
technically true from a GObject perspective, it's not accurate from the
API user's perspective.
Comment 2 Simon McVittie 2012-01-18 10:35:58 UTC 
Looks good, Reviewed-by: me (although I'm not officially a GLib reviewer)
Comment 3 David Zeuthen (not reading bugmail) 2012-01-18 15:23:43 UTC 
Comment on attachment 205513 [details] [review]
GDBusConnection: note that exit-on-close is sometimes TRUE

Sure. Thanks.
Comment 4 Will Thompson 2012-01-18 16:17:44 UTC 
Comment on attachment 205513 [details] [review]
GDBusConnection: note that exit-on-close is sometimes TRUE

Thanks!