GNOME Bugzilla – Bug 667586
autotools: Move towards GNOME Build API logic
Last modified: 2012-06-08 01:37:05 UTC
If configure exists, we now prefer it. This means in order to rerun autotools, we'll be relying on maintainer mode normally. However, developers can also just "rm configure". We use NOCONFIGURE=1 for autogen.sh with no arguments, under the now hard assumption it doesn't run configure.
Created attachment 204887 [details] [review] autotools: Move towards GNOME Build API logic
Created attachment 204888 [details] [review] autogen.sh: Honor NOCONFIGURE=1 http://people.gnome.org/~walters/docs/build-api.txt
If we go this route we actually can reduce a lot of the weird/differing logic between tarball versus git builds. If a tarball has a pregenerated configure script, under this new logic, we use it automatically. If it doesn't, we run autogen.sh.
This patch will however break a few modules: http://people.gnome.org/~fpeters/reports/autogen-noconfigure-support.html
Hm, it also breaks e.g. nss and nspr which have configure in a subdirectory. I think the simplest thing is to make the autogen.sh patches generate a toplevel configure which just execs the sub configure.
Review of attachment 204887 [details] [review]: Thank you for the patch. I don't want any modules within [ 'meta-gnome-core', 'meta-gnome-apps-tested' ] that were previously building modules to stop building. nspr and nss patches need to land before this is implemented. If a moduleset defines autogen-template, autogen.sh is erroneously run twice. For example, if the following attribute is set in a moduleset file: autogen-template="%(srcdir)s/%(autogen-sh)s --prefix %(prefix)s %(autogenargs)s" If a module's upstream updates configure.ac, autogen.sh isn't rerun.
Review of attachment 204888 [details] [review]: Thank you for the patch. ::: autogen.sh @@ +218,3 @@ gettext "gnome-doc-prepare not available"; echo fi + if test -z "$NOCONFIGURE"; then configure_without_autotools doesn't need this test as configure_without_autotools doesn't run autotool's configure.
Created attachment 215768 [details] [review] autogen.sh: Honor NOCONFIGURE=1 http://people.gnome.org/~walters/docs/build-api.txt
Review of attachment 215768 [details] [review]: Thank you. Looks good.
Attachment 215768 [details] pushed as 8ea5074 - autogen.sh: Honor NOCONFIGURE=1