After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667317 - audioringbuffer: Initialize dest_val to 0 in gst_ring_buffer_convert().
audioringbuffer: Initialize dest_val to 0 in gst_ring_buffer_convert().
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-04 21:04 UTC by Håvard Graff (hgr)
Modified: 2012-12-29 18:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (873 bytes, patch)
2012-01-04 21:04 UTC, Håvard Graff (hgr) 		none Details | Review

Description Håvard Graff (hgr) 2012-01-04 21:04:35 UTC 
Created attachment 204635 [details] [review]
patch

.
Comment 1 Vincent Penquerc'h 2012-01-18 10:38:43 UTC 
*dest_val already seems to be always initialized when TRUE is returned in current git.
Comment 2 Tim-Philipp Müller 2012-01-18 10:53:21 UTC 
So again it would be nice to understand the motivation behind this proposed change. It's fine of course, but why is it needed?
Comment 3 Akhil Laddha 2012-03-06 05:47:53 UTC 
Håvard, ping, can you please respond to comment#2 ?
Comment 4 Idar Tollefsen 2012-05-18 22:31:31 UTC 
It's a compiler warning fix.

It is initialized whenever TRUE is returned. It's not initialized whenever goto done is called (as far as the compiler can tell).
Comment 5 Tim-Philipp Müller 2012-12-29 18:56:19 UTC 
I think this should take care of it in gst_audio_info_convert(), which gst_audio_ring_buffer_convert() now uses:

commit b4def63f550c8780900d86b8524a7022deacbd14
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Sat Dec 29 14:29:53 2012 +0000

    audio: don't use uninitialized variable in debug log
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667317