GNOME Bugzilla – Bug 667269
Online Glom: improve single line fields and add anchor to URLs
Last modified: 2012-05-25 12:59:06 UTC
Created attachment 204584 [details] [review] comment fix Here are a couple of patches to improve the display of single line text fields in the details view. A couple of notes I should mention: * The single line patch uses the browser resize event which is not always fired properly by browsers. For instance, the resize event isn't fired when using the aero snap feature of gnome-shell on Ubuntu 11.11 with Firefox 8. I'm sure this is a bug but I thought I'd point it out. * The single line patch solidifies the fluid layout that Online Glom currently uses but you may want to consider a fixed layout or at list a fluid layout that turns to a fixed layout at a predefined minimum size. * Adding anchors to URLs should probably have a validation of the URLs string when editing support is added. I'm running my personal demo with these patches but you can decide for yourself if you think they're useful. No problem if you don't want them.
Created attachment 204585 [details] [review] add ellipsis to single line fields in details view
Created attachment 204586 [details] [review] add anchor tag for URL fields in the details view
Review of attachment 204584 [details] [review]: Sorry, but it looks right before and wrong with this patch.
Please feel free to push the two code changes to master, though it would be nice to have a comment about the resize event problem in the code, ideally with a link to a bug report. Thanks.
(In reply to comment #3) > Review of attachment 204584 [details] [review]: > > Sorry, but it looks right before and wrong with this patch. Yeah, not sure what I was thinking. I did this a couple of weeks ago so I don't really remember. Maybe the eggnog was especially good that evening. ;) (In reply to comment #4) > Please feel free to push the two code changes to master, I don't have my Online Glom development environment setup anymore so you'll have to integrate and commit the patches. > though it would be > nice to have a comment about the resize event problem in the code, ideally with > a link to a bug report. Here's the bug report for the specific problem I mentioned with Firefox and GNOME-Shell: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/912239 From what I've read, relying the resize event may be problematic in other browsers and other situations as well. There *might* be a way to avoid having to rely on the resize event by using HTML tables for the flowtable columns but I couldn't figure out anything from my brief investigation. I know that it's not possible to use the browser assigned column sizes with the fixed-layout table property like is done with the related list tables. [1] In this case, the "Open" navigation buttons won't be directly beside the field because the columns will have equal widths. Obviously this needs more investigation and may involve manually creating the ellipsis instead of relying the browser to render it. 1. The fixed-layout property is set in the related list tables here: https://gitorious.org/online-glom/gwt-glom/blobs/master/src/main/java/org/glom/web/client/ui/details/RelatedListTable.java#line78
I have pushed both patches, but I'll keep this open as a reminder to me to test that browser behaviour in some other environments.
The resize event seems to be working with the latest version of Firefox. It fires when using the aero snap feature of gnome-shell on Ubuntu 11.11 with Firefox 12.
So do we need to keep this bug open?
Nope, I'm closing it.