After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667226 - GSocket: fix an error return value
GSocket: fix an error return value
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-01-03 22:22 UTC by Claudio Saavedra
Modified: 2012-01-04 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GSocket: fix an error return value (929 bytes, patch)
2012-01-03 22:22 UTC, Claudio Saavedra 		reviewed Details | Review

Description Claudio Saavedra 2012-01-03 22:22:05 UTC 
Component: gio
Comment 1 Claudio Saavedra 2012-01-03 22:22:07 UTC 
Created attachment 204535 [details] [review]
GSocket: fix an error return value

g_socket_receive_with_blocking() claims to return -1 in error, its
type is a gssize, and yet it's returning FALSE if the initial
g_return_val_if_fail() call fails. Fishy.
Comment 2 Dan Winship 2012-01-04 15:30:35 UTC 
Comment on attachment 204535 [details] [review]
GSocket: fix an error return value

g_socket_send_with_blocking() has the same bug. Please commit after fixing that too.
Comment 3 Claudio Saavedra 2012-01-04 16:17:55 UTC 
Fixed the other method as well and pushed.