After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667220 - dvdspu: add NV12 support
dvdspu: add NV12 support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.0.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-03 21:52 UTC by Rob Clark
Modified: 2012-10-02 17:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dvdspu: add NV12 support (5.76 KB, patch)
2012-01-03 21:52 UTC, Rob Clark 		none Details | Review

Description Rob Clark 2012-01-03 21:52:01 UTC 
add support for NV12 format, to avoid unnecessary conversion NV12 -> I420 before dvdspu, and back to NV12 after, in cases where display and decoder are natively using NV12.  Since NV12 is similar to I420, it is fairly trivial to make dvdspu support both, and since NV12 seems common w/ hw accel decoders, seems like a good thing to support.

patch attached
Comment 1 Rob Clark 2012-01-03 21:52:25 UTC 
Created attachment 204527 [details] [review]
dvdspu: add NV12 support
Comment 2 Tim-Philipp Müller 2012-07-13 12:21:45 UTC 
I would prefer to see support for the video blend API in GstVideoOverlayComposition instead, which should cover even more formats (has other overheads of course, but I'm not sure if it matters in practice.)
Comment 3 Jan Schmidt 2012-10-02 17:37:15 UTC 
Thanks, applied to 0.10:

commit 61bebbd5144d06534491ac6f0746d6a4e7db07f7
Author: Rob Clark <rob@ti.com>
Date:   Mon Dec 26 22:04:04 2011 -0600

    dvdspu: add NV12 support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667220

and ported to 1.0, where it was trivially easy to add YV12 too:

commit 4dc648d3430b67592cf1413ccef415f70889d71e
Author: Rob Clark <rob@ti.com>
Date:   Mon Dec 26 22:04:04 2011 -0600

    dvdspu: add YV12 and NV12 support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667220
    
    Conflicts:
        gst/dvdspu/gstdvdspu.c
        gst/dvdspu/gstdvdspu.h
        gst/dvdspu/gstspu-pgs.c
        gst/dvdspu/gstspu-vobsub-render.c