After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667045 - x11: Force a _NET_WM_STATE check when the WM goes away
x11: Force a _NET_WM_STATE check when the WM goes away
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-12-30 20:13 UTC by Rui Matos
Modified: 2018-02-10 03:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x11: Force a _NET_WM_STATE check when the WM goes away (1.48 KB, patch)
2011-12-30 20:13 UTC, Rui Matos 		reviewed Details | Review

Description Rui Matos 2011-12-30 20:13:01 UTC 
I noticed that when changing to twm we'd get stuck with the unfocused theme
variant. This should fix it.
Comment 1 Rui Matos 2011-12-30 20:13:03 UTC 
Created attachment 204361 [details] [review]
x11: Force a _NET_WM_STATE check when the WM goes away

Otherwise if the new WM doesn't support _NET_WM_STATE or if there's no WM
coming up, we'd never update our toplevels' GdkWindowState.
Comment 2 Matthias Clasen 2012-01-03 03:58:45 UTC 
Review of attachment 204361 [details] [review]:

Wouldn't this fit better in the default handler for GdkX11Screen::window-manager-changed ?
Comment 3 Rui Matos 2012-01-09 16:25:16 UTC 
(In reply to comment #2)
> Wouldn't this fit better in the default handler for
> GdkX11Screen::window-manager-changed ?

It would be doing needless work when a _NET_SUPPORTING_WM_CHECK compliant WM is detected. We only really need to do it when the WM is going away since we don't know if the WM that comes next (if any) is going to support _NET_WM_STATE which would makes us refresh our state via the PropertyNotify.
Comment 4 Matthias Clasen 2018-02-10 03:38:56 UTC 
We're moving to gitlab! As part of this move, we are closing bugs that haven't seen activity in more than 5 years. If this issue is still imporant to you and
still relevant with GTK+ 3.22 or master, please consider creating a gitlab issue
for it.