After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666820 - Use GtkApplication
Use GtkApplication
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: lightsoff
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
Robert Carr
Depends on:
Blocks:
 
 
Reported: 2011-12-24 23:27 UTC by Robert Ancell
Modified: 2012-02-20 04:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
git format-patch that makes lightsoff use GtkApplication (2.45 KB, patch)
2012-01-05 18:38 UTC, Jim Zhang
committed Details | Review

Description Robert Ancell 2011-12-24 23:27:00 UTC
Use GtkApplication
Comment 1 Jim Zhang 2012-01-05 18:38:46 UTC
Created attachment 204704 [details] [review]
git format-patch that makes lightsoff use GtkApplication

[This is for Google Code-in 2011. GCI task here: http://www.google-melange.com/gci/task/view/google/gci2011/7231203]

This patch makes lightsoff use GtkApplication. To be honest, I referred quite a lot to the previously done GtkApplication tasks, so if anything is off, please let me know. It compiles, installs, and runs without any obvious new errors on my computer.
Comment 2 Robert Ancell 2012-01-05 22:06:23 UTC
Review of attachment 204704 [details] [review]:

Great work!  I've pushed this to master.