After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666478 - Vala should merge attributes on merge of namespaces
Vala should merge attributes on merge of namespaces
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Semantic Analyzer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks: 679587
 
 
Reported: 2011-12-19 02:47 UTC by Maciej (Matthew) Piechotka
Modified: 2012-07-12 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Merge-attributes-on-merge-of-namespace.patch (1.01 KB, patch)
2011-12-19 02:47 UTC, Maciej (Matthew) Piechotka 		none Details | Review
0001-Merge-attributes-on-merge-of-namespace.patch (1.07 KB, patch)
2011-12-19 03:04 UTC, Maciej (Matthew) Piechotka 		none Details | Review
0001-Merge-attributes-on-merge-of-namespace.patch (1.07 KB, patch)
2011-12-19 03:06 UTC, Maciej (Matthew) Piechotka 		none Details | Review
0001-Merge-attributes-on-merge-of-namespace.patch (948 bytes, patch)
2011-12-19 03:15 UTC, Maciej (Matthew) Piechotka 		none Details | Review

Description Maciej (Matthew) Piechotka 2011-12-19 02:47:59 UTC 
Created attachment 203818 [details] [review]
0001-Merge-attributes-on-merge-of-namespace.patch

Currently on merge the attributes are silently dropped. After this patch the attributes are treated as if they were specified sequentially.
Comment 1 Maciej (Matthew) Piechotka 2011-12-19 03:04:54 UTC 
Created attachment 203819 [details] [review]
0001-Merge-attributes-on-merge-of-namespace.patch

The error check was wrong (for example it fail for merging GLib from glib-2.0.vapi and gobject-2.0.vapi.
Comment 2 Maciej (Matthew) Piechotka 2011-12-19 03:06:17 UTC 
Created attachment 203820 [details] [review]
0001-Merge-attributes-on-merge-of-namespace.patch

Ups. Sorry - I forgot to call format-patch.
Comment 3 Maciej (Matthew) Piechotka 2011-12-19 03:15:19 UTC 
Created attachment 203822 [details] [review]
0001-Merge-attributes-on-merge-of-namespace.patch

Paper bug attachment.
Comment 4 Jürg Billeter 2012-07-12 12:09:36 UTC 
commit 4de3f6e7958557e8beb5eb73ffefb251433e6157
Author: Maciej Piechotka <uzytkownik2@gmail.com>
Date:   Mon Dec 19 03:24:28 2011 +0100

    Merge attributes on merge of namespace
    
    On merge the attribute of second namespace were silently ignored. This patch
    treats them as they were specified sequentially.
    
    Fixes bug 666478.