After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666243 - Shouldn't notify for incoming channels with no messages
Shouldn't notify for incoming channels with no messages
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: telepathy
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-12-15 11:29 UTC by Jonny Lamb
Modified: 2012-03-24 18:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
telepathyClient: only notify on new channels when asked to do so (2.96 KB, patch)
2011-12-15 11:29 UTC, Jonny Lamb 		none Details | Review
improved patch. (3.12 KB, patch)
2011-12-15 16:06 UTC, Jonny Lamb 		accepted-commit_now Details | Review

Description Jonny Lamb 2011-12-15 11:29:00 UTC 
Created attachment 203561 [details] [review]
telepathyClient: only notify on new channels when asked to do so

We need to notify when the channel dispatcher calls HandleChannels on
us with a channel we already handle. However, we don't want to notify
if we claim a new incoming channel which doesn't actually have
anything interesting in it yet.

For example, a new channel pops up just to give a delivery
notification. We want (or, need) to handle it but don't want to notify
for it.
Comment 1 Jonny Lamb 2011-12-15 16:06:00 UTC 
Created attachment 203586 [details] [review]
improved patch.

15:32 < cassidy> jonnylamb, right, so we rely on _displayPendingMessages() to call notify() ?
15:32 < jonnylamb> yep
15:34 < cassidy> jonnylamb, can you please add that in a comment.
Comment 2 Guillaume Desmottes 2011-12-15 16:36:04 UTC 
Review of attachment 203586 [details] [review]:

++
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-02-07 22:41:25 UTC 
Ping?
Comment 4 Akhil Laddha 2012-03-24 11:30:04 UTC 
Jonny, do you have git commit rights ? This patch was missed for 3.4.0 release.

Can you please commit patch post hard code freeze to 3.5.x or even for 3.4.1 if patch doesn't break any freeze in stable branch ?
Comment 5 Florian Müllner 2012-03-24 13:00:41 UTC 
(In reply to comment #4)
> Can you please commit patch post hard code freeze to 3.5.x or even for 3.4.1 if
> patch doesn't break any freeze in stable branch ?

Note that I expect us to branch after the 3.4.1 release - if that's the case, code freeze will remain in effect until then.
Comment 6 Jonny Lamb 2012-03-24 18:13:34 UTC 
This was merged in December:

http://git.gnome.org/browse/gnome-shell/commit/?id=69e26c6dee56c6bb

I'm not sure why I didn't close this bug at the time; sorry about that.