After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666210 - Deprecate connect/remove_property_change_handler
Deprecate connect/remove_property_change_handler
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks: 477705
 
 
Reported: 2011-12-14 23:32 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2013-12-09 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-12-14 23:32:39 UTC
Right now atkobject defines these abstract methods:

  /*
   * Specifies a function to be called when a property changes value
   */
guint (* connect_property_change_handler) (AtkObject *accessible,
                                           AtkPropertyChangeHandler *handler);
  /*
   * Removes a property change handler which was specified using
   * connect_property_change_handler
   */
void (* remove_property_change_handler)     (AtkObject *accessible,
                                             guint handler_id);

IMHO, those should be deprecated:

* This is basically a wrapper to "property-change" signal.
* It is only implemented by atkobject. I didn't find any implementation on gtk or clutter.
* It is no used by anyone relevant. Ie: at-spi2-atk add a global listener to "property-change"
* I only found a place using this: tests on the old gail repository. 

Although we are already thinking about how useful is property-change signal (bug 644747), those methods can be deprecated maintaining property-change.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-12-09 17:27:17 UTC
Done with commit 
https://git.gnome.org/browse/atk/commit/?id=f4563a7c35e6fc151b80402bc62ed8fdda0bd0c8