After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665938 - Do not dist gir_DATA
Do not dist gir_DATA
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
0.1.x
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2011-12-11 05:09 UTC by Yaakov Selkowitz
Modified: 2011-12-12 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not dist gir_DATA (1.50 KB, patch)
2011-12-11 05:09 UTC, Yaakov Selkowitz 		committed Details | Review

Description Yaakov Selkowitz 2011-12-11 05:09:17 UTC 
Attaching patch for the 0.1.x branch.
Comment 1 Yaakov Selkowitz 2011-12-11 05:09:58 UTC 
Created attachment 203205 [details] [review]
Do not dist gir_DATA

GIR files contain a shared-library attribute which varies per platform,
and therefore must not be disted; see bug 621611 for rationale.

Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Comment 2 Juan A. Suarez Romero 2011-12-12 16:08:22 UTC 
Review of attachment 203205 [details] [review]:

Patch accepted.

I've changed also Makefile.am to remove the .gir files so 'make distcheck' doesn't complain.
Comment 3 Juan A. Suarez Romero 2011-12-12 16:09:38 UTC 
commit ddc6b4fd62ffe3f5fe1d45a2441c30a2ec85b222
Author: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Date:   Sat Dec 10 22:54:42 2011 -0600

    Do not dist gir_DATA
    
    GIR files contain a shared-library attribute which varies per platform,
    and therefore must not be disted; see bug 621611 for rationale.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=665938
    
    Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

 libs/net/Makefile.am |    4 +++-
 src/Makefile.am      |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)