GNOME Bugzilla – Bug 665805
Add GSocketClient::action, for tracking socket client status
Last modified: 2011-12-23 19:59:43 UTC
Posting this here to give people a chance to comment. There's a libsoup patch that goes along with this to make the signals visible there, but anyway, this allows for a bunch of things: 1. network-related debugging (eg, the epiphany soup-fly extension) 2. progress UIs ("Looking up example.com..." "Connecting to example.com...") 3. timing network operations (eg, for the W3C Navigation Timing spec) 4. fiddling with the connections behind GSocketClient's back (eg, adjusting GTlsConnection flags, or calling setsockopt() on the local socket before calling connect() on it, which dcbw needs in NM to ensure that a particular request gets sent from a particular network interface).
Created attachment 203085 [details] [review] Add g_socket_connection_connect(), etc Previously it was more or less assumed that GSocketConnections were always connected, although this was not enforced. Make it explicit that they don't need to be, and add methods to connect them, and simplify GSocketClient by using those methods.
Created attachment 203086 [details] [review] Add GSocketClient::action, for tracking socket client status This can be used for debugging, or for progress UIs ("Connecting to example.com..."), or to tweak GTlsClientConnections before handshaking starts.
Is 'action' the right name here ? The enum values sound more like 'state' to me...
Well, I thought of them as "what action the GSocketClient is performing now". But I guess "action" might imply "GAction" now, so yeah, maybe "state" would be better. (Or "event"?)
or 'phase'...naming is hard. Got your Xmas shopping done ?
Comment on attachment 203085 [details] [review] Add g_socket_connection_connect(), etc pushed with "action" changed to "event" everywhere Attachment 203085 [details] pushed as 57f2799 - Add g_socket_connection_connect(), etc
Should this be closed, then ?
oops, yes