After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665328 - afc: minor fixes for the lock prompt dialog
afc: minor fixes for the lock prompt dialog
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afc backend and volume monitor
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2011-12-01 20:01 UTC by Cosimo Cecchi
Modified: 2011-12-01 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
afc: invert the choices order for the device passcode dialog (948 bytes, patch)
2011-12-01 20:01 UTC, Cosimo Cecchi 		committed Details | Review
afc: tweak the text used to report a device locked error (1.10 KB, patch)
2011-12-01 20:01 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-12-01 20:01:10 UTC 
See patches (untested, since I don't have such a device).
Comment 1 Cosimo Cecchi 2011-12-01 20:01:11 UTC 
Created attachment 202546 [details] [review]
afc: invert the choices order for the device passcode dialog

Buttons are layed out in reverse order, and the positive action is on
the right hand side.
Comment 2 Cosimo Cecchi 2011-12-01 20:01:14 UTC 
Created attachment 202547 [details] [review]
afc: tweak the text used to report a device locked error
Comment 3 Bastien Nocera 2011-12-01 20:06:44 UTC 
Review of attachment 202546 [details] [review]:

Looks good
Comment 4 Bastien Nocera 2011-12-01 20:12:55 UTC 
Review of attachment 202547 [details] [review]:

Looks good too (sorry, had to double-check that the device name was available and used in the popup before ack'ing this patch)
Comment 5 Cosimo Cecchi 2011-12-01 20:15:20 UTC 
Attachment 202546 [details] pushed as f952d7c - afc: invert the choices order for the device passcode dialog
Attachment 202547 [details] pushed as 4c0236e - afc: tweak the text used to report a device locked error

Pushed, thanks.