GNOME Bugzilla – Bug 665097
Fails to build from source with -Werror=format-security
Last modified: 2013-03-25 01:25:46 UTC
As reported here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647040 Beast failed to build from source with the flag -Werror=format-security enabled. The attached patch fixes this.
Created attachment 202343 [details] [review] Patch for build failure when GCC has hardening flags enabled
A revised patch has been attached.
Arg, sorry. Just spotted that this failed the last release. I make sure it's in the next one, thanks for the patch!
Created attachment 233858 [details] [review] Patch for build failure when GCC has hardening flags enabled (Last update: 2012-11-06) Hello, I updated the patch, you find it attached. Thanks!
Thank you, pushed to devel branch now, will be included in the next release.
Beast 0.7.8 does not build anymore: CXX bsescripthelper.lo CXX bseserver.lo bseserver.cc: In function 'void bse_server_require_pcm_input(BseServer*)': bseserver.cc:397:163: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:397:252: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:397:602: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:397:1173: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc: In function 'BseErrorType server_open_pcm_device(BseServer*, guint, guint, guint)': bseserver.cc:446:144: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:446:225: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:446:409: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:446:604: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc: In function 'BseErrorType server_open_midi_device(BseServer*)': bseserver.cc:468:149: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:468:233: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:468:412: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:468:609: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc: In function 'BseErrorType bse_server_open_devices(BseServer*)': bseserver.cc:523:166: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:523:245: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:523:397: error: format not a string literal and no format arguments [-Werror=format-security] bseserver.cc:523:596: error: format not a string literal and no format arguments [-Werror=format-security] cc1plus: some warnings being treated as errors make[4]: *** [bseserver.lo] Error 1 make[4]: Leaving directory `/tmp/buildd/beast-0.7.8/bse' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/tmp/buildd/beast-0.7.8/bse' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/tmp/buildd/beast-0.7.8' make[1]: *** [all] Error 2 make[1]: Leaving directory `/tmp/buildd/beast-0.7.8' dh_auto_build: make -j1 returned exit code 2 make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 E: Failed autobuilding of package Cheers,
(In reply to comment #6) > Beast 0.7.8 does not build anymore: [...] See comment #3, the fix went into the devel tree. It's part of the Beast-0.8.0 release now.