After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664956 - Remove statusbar
Remove statusbar
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: mahjongg
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-27 22:49 UTC by Robert Ancell
Modified: 2011-12-26 03:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Removes statusbar and moves content to toolbar (3.57 KB, patch)
2011-12-25 14:30 UTC, Martin Gergov 		committed Details | Review

Description Robert Ancell 2011-11-27 22:49:56 UTC 
Remove statusbar.  Move any remaining content (e.g. the clock) into the toolbar or into the game view.
Comment 1 Martin Gergov 2011-12-25 07:50:29 UTC 
Working on it...
Comment 2 Martin Gergov 2011-12-25 14:30:53 UTC 
Created attachment 204198 [details] [review]
Removes statusbar and moves content to toolbar
Comment 3 Robert Ancell 2011-12-26 03:06:55 UTC 
Review of attachment 204198 [details] [review]:

Patch is generally good.  Some minor things that should be done when doing patches in the future:
- Commit comment should match style of existing commits, so in this case it should have had a "mahjongg: " prefix
- Coding style should be consistent and match existing style.  In this case there were some spaces missing before the '(' in the function calls.

I've pushed this patch to master with some other changes that weren't specified in the bug report.  Thanks for your work!