GNOME Bugzilla – Bug 664955
Remove statusbar
Last modified: 2012-02-04 11:46:28 UTC
Remove statusbar. Move any remaining content (e.g. the clock) into the toolbar or into the game view.
I'll give this a try.
Created attachment 204793 [details] [review] iagno: add toolbar with GtkBuilder I thought I would first add a toolbar.
Created attachment 204796 [details] [review] iagno: removal of statusbar Moved content to the toolbar. The content is not properly aligned though, and I can't figure out why.
Review of attachment 204793 [details] [review]: Thanks Tiffany! Needs the following fixes: - You should catch the exception from builder.add_from_file and print it to stderr and exit with a failure code - You need to set hexpand and vexpand to true on GameView so it takes up the available space - The signals on the new and undo buttons need to be connected up
Created attachment 205162 [details] [review] iagno: set hexpand and vexpand to true on the GameView. This makes it so the view takes up the available space.
Review of attachment 205162 [details] [review]: Looks fine, but replace the tab characters with four spaces!
Created attachment 205163 [details] [review] iagno.vala: fixed spacing issue caused by last commit
Created attachment 205164 [details] [review] collapsing previous 4 patches into one.
Created attachment 205168 [details] [review] catch exception from bulder.add_from_file This patch takes care of catching the exception from bulder.add_from_file and setting the hexpand and vexpand to true on the GameView (as suggested above). I am thinking of removing the new and undo buttons from the toolbar. Tetravex only has the statusbar items the toolbar, so I think this will be more consistent. I haven't removed them yet. They were added using glade, and attempting to remove them has proven to be tricky thus far. Stay tuned...
I just learned that the only reason Tetravex doesn't have other items in the toolbar is due to a limitation in gtk. Therefore I will connect the signals shortly.
Created attachment 205740 [details] [review] iagno: add toolbar (GtkBuilder) and remove statusbar Contents of statusbar moved into the toolbar. Okay, all done. Signals (actions) are now hooked up. However, the statusbar items which are now in the toolbar are still not lined up properly. I don't have the solution for this problem.
Review of attachment 205740 [details] [review]: bob@alchemy:~/git/gnome-games/iagno$ make Making all in src make[1]: Entering directory `/home/bob/git/gnome-games/iagno/src' VALAC iagno_vala.stamp iagno.vala:47.5-51.6: error: `GLib.ActionEntry[]' not supported as type for constants iagno.vala:110.9-110.26: error: The name `add_action_entries' does not exist in the context of `Iagno.activate' add_action_entries (app_actions, this); ^^^^^^^^^^^^^^^^^^ Compilation failed: 2 error(s), 0 warning(s) Does this need a certain version of GLib/Vala?
new Gtk and new Glib.
I Robert, Actually, it's a new vala (as I just read the error more carefully.) T.
Created attachment 205771 [details] [review] iagno: add toolbar (GtkBuilder) and remove statusbar Contents of statusbar moved into the toolbar. This should work with the old Vala.
Review of attachment 205771 [details] [review]: Pushed. There's some minor alignment issues in the bar and I think it needs to be marked as a "primary toolbar" or similar to get the right theming (see other games how they do that). Improvement over what is there though so pushed.