After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664914 - Fails to build with newer glib version: only glib.h can be #include'd
Fails to build with newer glib version: only glib.h can be #include'd
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: clearlooks
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-27 14:28 UTC by Dominique Leuenberger
Modified: 2012-02-18 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
#include glib.h instead of other headers. (727 bytes, patch)
2011-11-27 14:29 UTC, Dominique Leuenberger
none Details | Review

Description Dominique Leuenberger 2011-11-27 14:28:47 UTC
While building gtk2-engines with glib 2.31, this build error appears:

/bin/sh ../../libtool --silent --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../engines/support -I../../engines/support -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14       -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -c -o clearlooks_draw_inverted.lo `test -f './src/clearlooks_draw_inverted.c' || echo './'`./src/clearlooks_draw_inverted.c
In file included from ./src/animation.c:31:0:
/usr/include/glib-2.0/glib/gtimer.h:28:2: error: #error "Only <glib.h> can be included directly."
make[2]: *** [animation.lo] Error 1
make[2]: *** Waiting for unfinished jobs..
Comment 1 Dominique Leuenberger 2011-11-27 14:29:55 UTC
Created attachment 202233 [details] [review]
#include glib.h instead of other headers.
Comment 2 Benjamin Berg 2012-02-18 15:06:57 UTC
I pushed the patch. Should do a new release soon, as some small fixes have accumulated (even if this is only useful for GTK+ 2.