GNOME Bugzilla – Bug 664851
Load _DBUS_APPLICATION_ID property, expose it via API
Last modified: 2011-12-15 15:13:10 UTC
This is used to associate GtkApplication -> X window, and will be consumed by gnome-shell.
Created attachment 202158 [details] [review] Load _DBUS_APPLICATION_ID property, expose it via API
Review of attachment 202158 [details] [review]: ::: src/core/window.c @@ +442,3 @@ + g_object_class_install_property (object_class, + PROP_DBUS_APPLICATION_ID, + g_param_spec_string ("dbus-applicaiton-id", typo: dbus-application-id
Shouldn't this depend on a gtk bug to set the new property ?
(In reply to comment #3) > Shouldn't this depend on a gtk bug to set the new property ? I'd intended to push this to the branch, done now: http://git.gnome.org/browse/gtk+/commit/?h=wip/gmenu&id=563f03f03322ba6a7ee197a0f9b8f8374b6901ae
Review of attachment 202158 [details] [review]: OK to commit with minor fixes ::: src/core/window-props.c @@ +1604,3 @@ + new_id = value->v.str; + + if (g_strcmp0 (new_id, current_id)) strongly prefer g_strcmp0() != 0 @@ +1611,3 @@ + window->dbus_application_id = g_strdup (new_id); + else + window->dbus_application_id = NULL; g_strdup (NULL) is defined to be NULL, fwiw
Attachment 202158 [details] pushed as 8ab5cc8 - Load _DBUS_APPLICATION_ID property, expose it via API