GNOME Bugzilla – Bug 664487
window label box colours should match the dash
Last modified: 2011-12-14 11:52:10 UTC
The labels that sit below the window thumbnails in the overview are currently opaque and black. It would be better if their fill and stroke colours matched those of the dash and workspace switcher. This would be both consistent and look better.
The css permit it with the window-caption class.
Created attachment 202644 [details] [review] patch
Created attachment 202645 [details] Result Here are a patch and the result.
Created attachment 202731 [details] [review] patch I looked at the wrong color. The only thing which was different from the dash was the opacity.
Created attachment 202732 [details] result And the new result.
Thanks for the patch and screenshot, Marc. This is really good. I had a quick look in the gnome-shell.css and it looks like the dash background isn't the colour that you're using for the labels. Can you check that? It would also be really awesome if you could try and match the designs for the window captions, which were updated recently: http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/overview-window-picker-6-workspaces.png A few things to notice here: * The text is bold and a bit bigger than you have it. * The captions themselves are bigger (around 30px tall). * No borders on the captions unless the pointer is hovering over window thumbnail. Thanks again!
(In reply to comment #6) > Thanks for the patch and screenshot, Marc. This is really good. > > I had a quick look in the gnome-shell.css and it looks like the dash background > isn't the colour that you're using for the labels. Can you check that? It's effectively the same background-color: #dash { color: #5f5f5f; font-size: 9pt; padding: 4px 0px; background-color: rgba(0, 0, 0, 0.5); border: 1px solid rgba(128, 128, 128, 0.4); border-left: 0px; border-radius: 0px 9px 9px 0px; } > It would also be really awesome if you could try and match the designs for the > window captions, which were updated recently: > > http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/overview-window-picker-6-workspaces.png > > A few things to notice here: > > * The text is bold and a bit bigger than you have it. > * The captions themselves are bigger (around 30px tall). > * No borders on the captions unless the pointer is hovering over window > thumbnail. > > Thanks again! I'll take a look at this later, I didn't saw the new mockups.
Created attachment 202875 [details] New result with some dynamicity
Created attachment 202877 [details] [review] Adding hover to the captions I'm not very happy with this patch, I just suck at css. There's probably a better way to render the borders, but without setting the borders on .window-caption, when I hover the window, the caption seems to be reduced (and last letters of the text dropped out for a …). Second point, I used add/remove_style_pseudo_class('hover') on the title, there's maybe a way to do this directly from css, but I didn't manage to do so.
Thanks for the patch, Marc! I've updated it and pushed it to master, so you're a proud GNOME now. ;) Let's deal with the highlight in bug 665310. http://git.gnome.org/browse/gnome-shell/commit/?id=1acec65c5eae6235e6a7db554408e0dafcfad652