After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664416 - Turning a switch on/off in the menu of a system status icon hides it
Turning a switch on/off in the menu of a system status icon hides it
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.2.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-20 13:09 UTC by Simon Werbeck
Modified: 2012-02-06 15:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PopupSwitchMenuItem: allow toggling without closing the menu (1003 bytes, patch)
2011-11-21 13:18 UTC, Giovanni Campagna 		needs-work Details | Review
PopupSwitchMenuItem: allow toggling without closing the menu (1.51 KB, patch)
2011-12-07 14:42 UTC, Giovanni Campagna 		committed Details | Review

Description Simon Werbeck 2011-11-20 13:09:39 UTC 
When turning a switch in a gnome-shell menu (eg. of the bluetooth status icon) on or off, the menu gets closed. This is a bit annoying because you have to reopen the menu, if you want to make further changes (which can be expected, when you're turning something _on_).

Steps to Reproduce:
1) Click on the bluetooth status icon
2) Turn Bluetooth switch on
The menu will close, so you will have to reopen it to make further changes
Comment 1 Matthias Clasen 2011-11-20 20:47:49 UTC 
GTK+ gives you the choice by using either Enter to toggle and close the menu, or Space to toggle and keep the menu open. Might be worth doing the same in the shell menus ?
Comment 2 Giovanni Campagna 2011-11-21 13:18:23 UTC 
Created attachment 201806 [details] [review]
PopupSwitchMenuItem: allow toggling without closing the menu

Similar to what Gtk does, now toggling with Space does not close
the menu.
Comment 3 Rui Matos 2011-11-23 01:10:43 UTC 
Review of attachment 201806 [details] [review]:

The notifications switch in userMenu.js has to be changed to connect to the toggled signal.
Comment 4 Giovanni Campagna 2011-12-07 14:42:40 UTC 
Created attachment 202993 [details] [review]
PopupSwitchMenuItem: allow toggling without closing the menu

Similar to what Gtk does, now toggling with Space does not close
the menu.

Rebased, and with the userMenu fix.
Comment 5 Rui Matos 2011-12-12 03:40:35 UTC 
Review of attachment 202993 [details] [review]:

Looks good.
Comment 6 Giovanni Campagna 2012-02-06 15:49:39 UTC 
Attachment 202993 [details] pushed as ee6bc33 - PopupSwitchMenuItem: allow toggling without closing the menu