After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664339 - matroskamux: support for audio/x-adpcm
matroskamux: support for audio/x-adpcm
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-18 15:40 UTC by Nicola
Modified: 2013-12-24 09:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basic adpcm support (1.96 KB, patch)
2012-01-14 19:05 UTC, Nicola
committed Details | Review
correct max block align is 8192 not 8096 (953 bytes, patch)
2013-12-23 23:46 UTC, Nicola
committed Details | Review

Description Nicola 2011-11-18 15:40:07 UTC
Could please add this audio codec?
Comment 1 Tim-Philipp Müller 2011-11-19 23:48:47 UTC
Could you provide a sample file please?
Comment 2 Tim-Philipp Müller 2011-11-19 23:49:13 UTC
Oh, nevermind, you are talking about the muxer.
Comment 3 Nicola 2012-01-14 19:05:19 UTC
Created attachment 205270 [details] [review]
basic adpcm support

I'm sure some bits are still missing however I can mux with:

gst-launch -e -v audiotestsrc ! adpcmenc ! matroskamux ! filesink location=/tmp/test.mkv

and playback with:

gst-launch -v filesrc location=/tmp/test.mkv ! matroskademux ! adpcmdec ! pulsesink

Steve Lhomme suggested to use A_MS/ACM for codec mapping,

Nicola
Comment 4 Sebastian Dröge (slomo) 2013-12-23 14:47:53 UTC
commit 4baf8080f2cbd2b6cebdefd4f6d723c762dc1ef9
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 23 15:46:48 2013 +0100

    matroskamux: Use correct codec id for ADPCM/DVI

commit 7cae8922cb1d622cd9fcf2563e165ec81465f8a8
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 23 15:44:30 2013 +0100

    matroskademux: Check for the correct size of codec_data in the ACM case

commit 00ea1cb00398ac79f14f771f00ba4cfbaeb1ca34
Author: Nicola Murino <nicola.murino@gmail.com>
Date:   Sat Jan 14 19:58:17 2012 +0100

    matroskamux: basic adpcm support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=664339
Comment 5 Nicola 2013-12-23 23:46:05 UTC
Created attachment 264825 [details] [review]
correct max block align is 8192 not 8096
Comment 6 Sebastian Dröge (slomo) 2013-12-24 09:00:41 UTC
Comment on attachment 264825 [details] [review]
correct max block align is 8192 not 8096

commit 5b1108dd5f88bfa67655f90d7de9a8308a183f19
Author: Nicola Murino <nicola.murino@gmail.com>
Date:   Tue Dec 24 00:43:39 2013 +0100

    matroskamux: adpcm max block align is 8192