GNOME Bugzilla – Bug 664296
Shows a printer removed notification
Last modified: 2015-04-13 11:16:56 UTC
Created attachment 201613 [details] screenshot When I remove a printer from the Printers panel I get a system notification that a printer was removed. Why do we show this? It seems pretty strange to me.
Do you suggests to remove the notification from gnome-settings-daemon entirely? The notification doesn't seem strange to me. It seems to me pretty valid to notify user about removal of a printer. And unfortunately, we can not disable the notification for the case when the user removes the printer in g-c-c. Marek
1. We should not be using notifications for actions initiated by the user in the foreground application - ever. 2. It isn't clear to me why I'd want a notification for this even if the printer is removed by an admin or some other way that me explicitly removing it. I can't see a good reason for it and the design didn't call for it. Until one of those happen my preference is to remove it.
Created attachment 301200 [details] [review] Do not show notification when printer is removed Patch removes showing of notification when printer is removed. This action is initiated by user, so he already know about it.
Review of attachment 301200 [details] [review]: Thank you for the patch. It fixes this bug for me. I'll ask you just for a change in the commit message. Place the 'print-notifications: ...' into the subject of the commit message and make it a little shorter (~60 letters), something like 'print-notifications: Don't show printer-removed notification'. It would be also good to explain there why you haven't removed the subscription to the 'printer-deleted' event. I'll accept it after the change (with accepted-commit_after_freeze).
Created attachment 301201 [details] [review] Do not show notification when printer is removed Fixed subject and comment about subscription.
Review of attachment 301201 [details] [review]: Thank you for the changes. I'll push the patch to master once the 3-16 branch is created.
Created attachment 301450 [details] [review] Do not show notification when printer is removed Fixed comments in patch.
"actual" is a "false friend". Updated is the word you were looking for. I've also added your full name as the authorship of the patch. Thanks!