After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664204 - workspace switcher - have a visual effect on hover
workspace switcher - have a visual effect on hover
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-11-16 14:24 UTC by Allan Day
Modified: 2021-07-05 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
workspaceThumbnail: draw an indicator around a drop target (5.92 KB, patch)
2011-11-27 17:40 UTC, Stefano Facchini
needs-work Details | Review
Add a visual effect on hover for workspace thumbnails (8.34 KB, patch)
2013-10-03 21:53 UTC, Tarun Joshi
none Details | Review
workspaceThumbnail: add visual effect on hover for workspace thumbnails (9.74 KB, patch)
2013-10-06 13:38 UTC, Tarun Joshi
none Details | Review

Description Allan Day 2011-11-16 14:24:53 UTC
The workspace thumbnails in the switcher should visually react when the pointer is positioned above them. This will act as a hint that they are actionable. It is also useful when dragging objects onto the thumbnail, since it indicates at what point the object can be released to complete a drag and drop operation.
Comment 1 Jakub Steiner 2011-11-21 16:20:02 UTC
This is closely related to bug #662087. I recommend making the active workspace thumbnail border to be "4px solid rgba(255,255,255,.7)" and when it prelights #fff as drop target.
Comment 2 Stefano Facchini 2011-11-27 17:40:26 UTC
Created attachment 202247 [details] [review]
workspaceThumbnail: draw an indicator around a drop target

We draw an indicator similiar to the active workspace indicator
around a thumbnail when it is a drop target
Comment 3 Stefano Facchini 2011-11-27 17:42:11 UTC
(In reply to comment #2)
> Created an attachment (id=202247) [details] [review]
> workspaceThumbnail: draw an indicator around a drop target
> 
> We draw an indicator similiar to the active workspace indicator
> around a thumbnail when it is a drop target

This patch depends on the ones attached at bugs #662087 and #664201
Comment 4 Allan Day 2011-11-30 15:49:55 UTC
Note that there is some updated artwork that is relevant to this bug:

http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/overview-window-picker-6-workspaces.png
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-12-01 17:30:41 UTC
(In reply to comment #4)
> Note that there is some updated artwork that is relevant to this bug:
> 
> http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/overview-window-picker-6-workspaces.png

The cursor isn't over the workspace switcher, so I don't see how this is relevant.
Comment 6 Allan Day 2011-12-01 17:56:01 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Note that there is some updated artwork that is relevant to this bug:
> > 
> > http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/overview-window-picker-6-workspaces.png
> 
> The cursor isn't over the workspace switcher, so I don't see how this is
> relevant.

The visual effect that is applied to the window thumbnail (see bug 665310) could be applied to the workspace thumbnail.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-06-01 10:53:37 UTC
Review of attachment 202247 [details] [review]:

Why not add/remove the pseudo class on the actual indicator when it becomes a drop target? Then we can use CSS transitions on the border-color.

::: js/ui/workspaceThumbnail.js
@@ +203,3 @@
         this._slidePosition = 0; // Fully slid in
         this._collapseFraction = 0; // Not collapsed
+        this.isDropTarget = false;

You don't seem to read back isDropTarget, so I'm not sure what it's for.
Comment 8 Allan Day 2012-11-01 09:37:40 UTC
Work on this bug seems to have halted; I assume that it is fair game if anyone wants to pick it up.
Comment 9 Stéphane Démurget 2012-11-05 23:16:11 UTC
FYI, I'm working on this one.
Comment 10 Stéphane Démurget 2012-11-06 12:54:27 UTC
I simplified the patch a lot and added :hover transition, but that is not what is asked in the first place: the point is to have a visual effect on hover. I've got two questions.

First, while I played with my patch working only on dnd, I found dragging vertically is weird because sometimes you have a border, sometimes not, and it's difficult to understand how the drop works. Wouldn't it be better to also add a border to the placeholder, maybe even replace the image altogether?

Second, about the implementation, there certainly is a good reason, but why isn't the indicator in WorkspaceThumbnail itself? couldn't it have a transparent border that goes to grey if selected/hover, and even brighter #fff on both? IMHO it would simplify things a lot, including positioning on allocate.

If this can not be used, I'd like the best strategy to achieve this: we need to have up to two indicators, what about .workspace-thumbnail-indicator.selection and .workspace-thumbnail-indicator.hover (not as a pseudo selector since it's not a state, its a purpose) and use :hover on both (sure, .hover:hover looks bad). How can I handle enter/leave events to add the :hover pseudo-selector?
Comment 11 Stéphane Démurget 2012-11-07 15:35:08 UTC
For the first point, here's a video explaining the "problem" (do not take care of the wrong border colors): http://zzrough.free.fr/files/public/gnome-shell-664204-Workspace-switcher-visual-effect-on-hover/workspace-hover-highlight.webm

I think it might make sense to also have the border on the placeholder.
Comment 12 Allan Day 2012-11-13 10:02:31 UTC
(In reply to comment #11)
> For the first point, here's a video explaining the "problem" (do not take care
> of the wrong border colors):
> http://zzrough.free.fr/files/public/gnome-shell-664204-Workspace-switcher-visual-effect-on-hover/workspace-hover-highlight.webm
> 
> I think it might make sense to also have the border on the placeholder.

Looks good to me. :)
Comment 13 Allan Day 2012-11-20 10:05:53 UTC
Any progress on this?
Comment 14 Stéphane Démurget 2012-11-20 12:33:10 UTC
I'll try to finish that in the next days.
Comment 15 Tarun Joshi 2013-10-03 21:53:45 UTC
Created attachment 256427 [details] [review]
Add a visual effect on hover for workspace thumbnails

Hope nobody minds me taking over this bug :)
Comment 16 Tarun Joshi 2013-10-06 13:38:28 UTC
Created attachment 256573 [details] [review]
workspaceThumbnail: add visual effect on hover for workspace thumbnails

updated patch.
Comment 17 Carlos Soriano 2014-01-15 19:06:43 UTC
Hi Tarun,

Do you mind updating the patch so I can test it and try to review it?
I tried to update it quick and I saw some visual errors, so maybe it needs some work than just merge the changes.
Comment 18 GNOME Infrastructure Team 2021-07-05 14:08:24 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of  gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/

Thank you for your understanding and your help.