GNOME Bugzilla – Bug 664045
Tab tooltips do not show (client type-triggered) phone symbols
Last modified: 2012-02-17 13:26:07 UTC
The tooltips for chat tabs show the contact's status message (if any), but they do not show the phone symbol used on the contact list to say that the contact is connected via a mobile device. It would be nice if they showed basically the same information as you see in the contact list.
Sounds like a good idea.
Created attachment 202011 [details] screenshot I started implementing this but is it me or the phone icon reduce the height of the label next to it?
Either I was crazy or this has been fixed in Gtk+ master. That doesn't seem to be the case any more.
Created attachment 207849 [details] [review] chat-window: display a phone icon in the tab label
Review of attachment 207849 [details] [review]: I'm feeling phony! ::: src/empathy-chat-window.c @@ +926,3 @@ + types = empathy_contact_get_client_types (remote_contact); + if (g_strv_length ((gchar **) types) > 0 && + !tp_strdiff (types[0], "phone")) { If 'types' is NULL, g_strv_length will critical. And you don't care about how long it is, you just want to know if it's empty. So instead: if (types != NULL && !tp_strdiff (types[0], "phone")) will do it. (If g_strv_length (types) == 0, then types[0] == NULL != "phone".)
Attachment 207849 [details] pushed as 3ffffaa - chat-window: display a phone icon in the tab label