After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663761 - gtk: Fix GtkCellRenderer ignoring keycodes
gtk: Fix GtkCellRenderer ignoring keycodes
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-11-10 11:01 UTC by Bastien Nocera
Modified: 2011-11-10 14:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk: Fix GtkCellRenderer ignoring keycodes (1.28 KB, patch)
2011-11-10 11:01 UTC, Bastien Nocera 		committed Details | Review
gtk: Fix parsing of accelerators with keycodes (2.11 KB, patch)
2011-11-10 11:01 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2011-11-10 11:01:25 UTC 
.
Comment 1 Bastien Nocera 2011-11-10 11:01:33 UTC 
Created attachment 201128 [details] [review]
gtk: Fix GtkCellRenderer ignoring keycodes

We should use the new helper code rather than invent our own
functions again.
Comment 2 Bastien Nocera 2011-11-10 11:01:51 UTC 
Created attachment 201129 [details] [review]
gtk: Fix parsing of accelerators with keycodes

GDK_KEY_VoidSymbol is not the same as keycode 0. This fixes
keycodes such as "0xb3" being parsed as "VoidSymbol" keysyms.
Comment 3 Matthias Clasen 2011-11-10 13:28:40 UTC 
Review of attachment 201128 [details] [review]:

Looks good to me
Comment 4 Matthias Clasen 2011-11-10 13:45:57 UTC 
Review of attachment 201129 [details] [review]:

Looks good
Comment 5 Bastien Nocera 2011-11-10 14:34:41 UTC 
commit c30d313afcc6941d8c64c83854fdd0fe33049917
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Nov 10 10:59:44 2011 +0000

    gtk: Fix parsing of accelerators with keycodes
    
    GDK_KEY_VoidSymbol is not the same as keycode 0. This fixes
    keycodes such as "0xb3" being parsed as "VoidSymbol" keysyms.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=663761

commit d69c7f4776506efd0c66dccf7e16bb9461f040c0
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Nov 10 10:58:37 2011 +0000

    gtk: Fix GtkCellRenderer ignoring keycodes
    
    We should use the new helper code rather than invent our own
    functions again.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=663761