After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663391 - theoraenc: misc small tweaks
theoraenc: misc small tweaks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-04 11:23 UTC by Vincent Penquerc'h
Modified: 2011-11-07 18:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theoraenc: make logically static const data just so (832 bytes, patch)
2011-11-04 11:23 UTC, Vincent Penquerc'h 		committed Details | Review
theoraenc: use th_packet_iskeyframe instead of peeking at bits (1.06 KB, patch)
2011-11-04 11:23 UTC, Vincent Penquerc'h 		committed Details | Review
theoraenc: trivial comment typos fixes (1.33 KB, patch)
2011-11-04 11:23 UTC, Vincent Penquerc'h 		committed Details | Review
theoraenc: warn when trying to set an ignored obsolete property (911 bytes, patch)
2011-11-04 11:23 UTC, Vincent Penquerc'h 		committed Details | Review
theoraenc: refuse to get to READY if the encoder was disabled (1.22 KB, patch)
2011-11-04 11:23 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-11-04 11:23:09 UTC 
make logically static const data just so
use th_packet_iskeyframe instead of peeking at bits
trivial comment typos fixes
warn when trying to set an ignored obsolete property
refuse to get to READY if the encoder was disabled
Comment 1 Vincent Penquerc'h 2011-11-04 11:23:12 UTC 
Created attachment 200677 [details] [review]
theoraenc: make logically static const data just so
Comment 2 Vincent Penquerc'h 2011-11-04 11:23:14 UTC 
Created attachment 200678 [details] [review]
theoraenc: use th_packet_iskeyframe instead of peeking at bits
Comment 3 Vincent Penquerc'h 2011-11-04 11:23:17 UTC 
Created attachment 200679 [details] [review]
theoraenc: trivial comment typos fixes
Comment 4 Vincent Penquerc'h 2011-11-04 11:23:20 UTC 
Created attachment 200680 [details] [review]
theoraenc: warn when trying to set an ignored obsolete property
Comment 5 Vincent Penquerc'h 2011-11-04 11:23:23 UTC 
Created attachment 200681 [details] [review]
theoraenc: refuse to get to READY if the encoder was disabled
Comment 6 Vincent Penquerc'h 2011-11-07 12:29:08 UTC 
commit a81cb3ef7f7b06098278c4270bc61c4c05b49dcb
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Nov 4 10:57:40 2011 +0000

    theoraenc: make logically static const data just so
    
    https://bugzilla.gnome.org/show_bug.cgi?id=663391

commit c1aab3e0a73bf50680231833da4a083ba96545b7
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Nov 4 10:58:15 2011 +0000

    theoraenc: use th_packet_iskeyframe instead of peeking at bits
    
    https://bugzilla.gnome.org/show_bug.cgi?id=663391

commit ffbe58fd5a4c0e5e7a20fb57389f383878f7ec6f
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Nov 4 10:59:00 2011 +0000

    theoraenc: trivial comment typos fixes
    
    https://bugzilla.gnome.org/show_bug.cgi?id=663391

commit 0c4ccb4f9c3e9f6084f82f16c548a5bdeeb690ae
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Nov 4 10:59:12 2011 +0000

    theoraenc: warn when trying to set an ignored obsolete property
    
    https://bugzilla.gnome.org/show_bug.cgi?id=663391

commit 10811d63f973a2872e0e684a795d1db49eca65c3
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Nov 4 11:10:46 2011 +0000

    theoraenc: refuse to get to READY if the encoder was disabled
    
    https://bugzilla.gnome.org/show_bug.cgi?id=663391