GNOME Bugzilla – Bug 662895
More deprecation fixes
Last modified: 2012-03-13 04:48:55 UTC
More GDK breakage, more mutter fixage
Created attachment 200135 [details] [review] mutter-window-demo: Remove deprecated stuff
Created attachment 200136 [details] [review] mutter-mag: Remove deprecated stuff
Created attachment 200137 [details] [review] ui: Remove deprecated stuff
Review of attachment 200136 [details] [review]: This is not just removing deprecated stuff though. It also gets rid of the keyboard grab. At the very least, the commit message should probably explain why that is not needed anymore.
Review of attachment 200137 [details] [review]: ::: src/ui/ui.c @@ +214,1 @@ gdk_event_set_device (gevent, gdk_device_manager_get_client_pointer (gmanager)); Could just use gdevice here as well, then ?
Review of attachment 200135 [details] [review]: This one looks pretty obvious. The only thing to verify here is that the table->grid replacement doesn't mess up any expand behaviour. I assume you've tested that ?
Created attachment 200186 [details] [review] mutter-window-demo: Remove deprecated stuff I tested it by running it, but not by resizing it.
Created attachment 200188 [details] [review] mutter-mag: Remove deprecated stuff Remove a keyboard grab, as there's no easy way to get a list of all keyboard-like devices for us to do a grab on. This a better commit message? psst.. a new GDK API for grabbing all keyboard-like devices wouldn't be bad
Created attachment 200189 [details] [review] p# Attachment to Bug 662895 - More deprecation fixes ui: Remove deprecated stuff Sure thing.
Created attachment 200190 [details] [review] theme-viewer: Fix layout Fix the expand there.
Created attachment 200191 [details] [review] theme-viewer: Fix invisible borders And while I'm at it, why not. This fixes theme-viewer to be useful again.
Review of attachment 200186 [details] [review]: Ok, looks good then
Review of attachment 200188 [details] [review]: Well, given that you are only grabbing the client_pointer and not all pointer-like devices, I don't see why you couldn't just do the same for the keyboard. Use gdk_device_get_associated_device, to get the keyboard to grab, I think...
Review of attachment 200189 [details] [review]: Looks fine to me.
Review of attachment 200190 [details] [review]: Looks ok
Created attachment 200203 [details] [review] mutter-mag: Remove deprecated stuff Ah. That's a somewhat quirky API, but it sort of makes sense.
Created attachment 200204 [details] [review] mutter-mag: Quit when the user hits escape
Attachment 200186 [details] pushed as 7ecd673 - mutter-window-demo: Remove deprecated stuff Attachment 200190 [details] pushed as 8087872 - theme-viewer: Fix layout Pushed the ACN patches.
Review of attachment 200203 [details] [review]: Looks good to me now.
Review of attachment 200204 [details] [review]: Looks correct, this was clearly the intention all along.
Attachment 200203 [details] pushed as 1b04a40 - mutter-mag: Remove deprecated stuff Attachment 200204 [details] pushed as 3beb33b - mutter-mag: Quit when the user hits escape
Comment on attachment 200191 [details] [review] theme-viewer: Fix invisible borders Attachment 200191 [details] pushed as 0b7f2f8 - theme-viewer: Fix invisible borders It seems this patch never got pushed for whatever reason. Pushing now.