After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662727 - new-call/new-convo dialogs should listen to capabilities changes
new-call/new-convo dialogs should listen to capabilities changes
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-26 00:22 UTC by Danielle Madeley
Modified: 2011-10-27 22:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.61 KB, patch)
2011-10-26 03:33 UTC, Danielle Madeley 		accepted-commit_now Details | Review

Description Danielle Madeley 2011-10-26 00:22:09 UTC 
As it stands, the new new-call and new-convo dialogs make a GetContactAttributes call, which because its a Get* verb, only returns information known to the CM, and places network requests on the queue to be signalled later. For this reason, the dialog should listen to updates of a contact's capabilities and refilter when they change.

E.g. I enter a handle which is unknown to the CM, Get request returns an empty set of capabilities, some seconds later it emits ContactCapabilitiesChanged with the correct capabilities. The contact should now appear in the dialog.
Comment 2 Guillaume Desmottes 2011-10-26 11:22:29 UTC 
Review of attachment 199991 [details] [review]:

++

2.32 too, I hink
Comment 3 Danielle Madeley 2011-10-27 00:52:39 UTC 
(In reply to comment #2)

> ++

COMMITILATED.

> 2.32 too, I hink

Do you mean 3.2?
Comment 4 Guillaume Desmottes 2011-10-27 11:36:55 UTC 
Heuu yeah of course.
Comment 5 Danielle Madeley 2011-10-27 22:46:55 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.