GNOME Bugzilla – Bug 662708
Add vapi bindings generation
Last modified: 2011-12-13 15:27:51 UTC
Generate Vala bindings.
Created attachment 199959 [details] [review] Add vapi bindings generation
Attachment 199959 [details] pushed as 8f1d3d0 - Add vapi bindings generation
This patch has broken the build of GTK-VNC with GTK-2. Please update it to ensure the vala bindings generation is disabled if --with-gtk=2.0 is passed to configure.
This also breaks the build with gtk-3.0 here: GEN GtkVnc-2.0.gir Package gtk-vnc-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `gtk-vnc-2.0.pc' to the PKG_CONFIG_PATH environment variable No package 'gtk-vnc-2.0' found In file included from <stdin>:4:0: /home/teuf/hack/gtk-vnc/src/vnccairoframebuffer.h:25:21: fatal error: gdk/gdk.h: No such file or directory compilation terminated. Error while processing the source. make[3]: *** [GtkVnc-2.0.gir] Error 1
I believe I pushed fixes for both cases. Could you guys please check.
Created attachment 202364 [details] [review] Proposed patch Reopening since I don't think overriding PKG_CONFIG_PATH is a great idea. This patch solves this by using --include-uninstalled. However, I needed to change --pkg to --pkg-export, and I'm not sure this is the right thing to do here since I have no idea why vala needs --pkg in the first place
(In reply to comment #6) > Created an attachment (id=202364) [details] [review] > Proposed patch > > Reopening since I don't think overriding PKG_CONFIG_PATH is a great idea. This > patch solves this by using --include-uninstalled. However, I needed to change > --pkg to --pkg-export, and I'm not sure this is the right thing to do here > since I have no idea why vala needs --pkg in the first place So you want us to switch from a working solution to a one you are not sure about yourself? :)
Have you read the patch changelog ? The current solution is broken if glib/gobject/... are not installed in pkg-config default search path.
The change from --pkg to --pkg-export should be a no-op afaict, since '--pkg-export' defaults to the value of '--pkg' if omitted --pkg-export=PACKAGE List of pkg-config packages that are provided by the generated gir. This option can be specified multiple times if the gir provides more packages. If not specified, the packages specified with --pkg= will be used.
(In reply to comment #8) > Have you read the patch changelog ? The current solution is broken if > glib/gobject/... are not installed in pkg-config default search path. No, I only read your comment here. Its a real bug then. I'll look at this later if its not resolved by then. :)
Other people are hitting this issue, see bug #664588, should I push this patch?
*** Bug 664588 has been marked as a duplicate of this bug. ***
Comment on attachment 202364 [details] [review] Proposed patch I pushed this patch since I hit this issue again
And I pushed a follow-up patch doing the same for GVncPulse which I hadn't noticed at first...