After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662685 - contact-display: Don't show non-IM contacts as "offline"
contact-display: Don't show non-IM contacts as "offline"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-25 16:14 UTC by Florian Müllner
Modified: 2012-01-25 21:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
contact-display: Don't show non-IM contacts as "offline" (2.35 KB, patch)
2011-10-25 16:14 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-10-25 16:14:51 UTC 
Mentioned by Jon in bug 662681.
Comment 1 Florian Müllner 2011-10-25 16:14:54 UTC 
Created attachment 199945 [details] [review]
contact-display: Don't show non-IM contacts as "offline"

Currently we display IM status information for every contact, falling
back to "offline" if the contact does not have an associated IM
account. Instead, don't show IM presence in this case.
Comment 2 Owen Taylor 2012-01-25 20:12:05 UTC 
Review of attachment 199945 [details] [review]:

Looks OK (you could alternatively not create the label at all, or even return null from _createPresence(), but doesn't matter much)
Comment 3 Florian Müllner 2012-01-25 21:21:00 UTC 
Attachment 199945 [details] pushed as b0ae596 - contact-display: Don't show non-IM contacts as "offline"