After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662085 - The test for gnome proxy support is built on platforms that don't support it
The test for gnome proxy support is built on platforms that don't support it
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: network
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 666622 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-18 11:44 UTC by Kalev Lember
Modified: 2012-01-05 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proxy/gnome: Only build the test if we are building gnome proxy support (752 bytes, patch)
2011-10-18 11:47 UTC, Kalev Lember
committed Details | Review

Description Kalev Lember 2011-10-18 11:44:02 UTC
In glib-networking, when building for non-GNOME platforms (e.g. win32), the gnome proxy test build can fail because gdesktop-enums.h isn't available. It might make sense to conditionally build the test only when building gnome proxy support.
Comment 1 Kalev Lember 2011-10-18 11:47:16 UTC
Created attachment 199325 [details] [review]
proxy/gnome: Only build the test if we are building gnome proxy support
Comment 2 Dan Winship 2011-10-19 15:19:17 UTC
fixed in master. thanks
Comment 3 Dan Winship 2011-12-21 15:31:52 UTC
*** Bug 666622 has been marked as a duplicate of this bug. ***
Comment 4 Nicolas Dufresne (ndufresne) 2011-12-21 16:09:48 UTC
> already fixed on master and there are no more GNOME 3.2-series releases, so
> there's little point in pulling it up to the glib-2-30 branch

I don't want really want to argue, but bugfix release should not be tied with planned releases date. Also glib has 2.30.2, I don't see why glib-networking would not have had one too. Unless something have changed, this is the stable branch until 2.32 is out.
Comment 5 Dan Winship 2012-01-04 16:05:17 UTC
(In reply to comment #4)
> I don't want really want to argue, but bugfix release should not be tied with
> planned releases date. Also glib has 2.30.2, I don't see why glib-networking
> would not have had one too.

Yeah, that was a bug... I just uploaded 2.30.2 with this fix and a few others.
Comment 6 Nicolas Dufresne (ndufresne) 2012-01-05 17:07:23 UTC
(In reply to comment #5)
> Yeah, that was a bug... I just uploaded 2.30.2 with this fix and a few others.

thanks