After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661954 - G_DISABLE_DEPRECATED conflicts with -Wmissing-prototypes
G_DISABLE_DEPRECATED conflicts with -Wmissing-prototypes
Status: RESOLVED DUPLICATE of bug 661344
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-10-17 01:57 UTC by Allison Karlitskaya (desrt)
Modified: 2011-10-17 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Allison Karlitskaya (desrt) 2011-10-17 01:57:28 UTC
I've been tidying up a bit tonight getting GLib ready for -Wmissing-prototypes.  It's just about ready to turn on by default.

The last remaining issue is that G_DISABLE_DEPRECATED interacts pretty badly with it.  When we define that, we skip the declarations in our headers, which of course triggers the warning.  imho, this is a pretty insane thing to be doing anyway, so we should stop it.

There are two ways forward that I can see:

  1) now that we do attribute-based deprecations, stop it with the wrapping
     of functions (at least) in G_DISABLE_DEPRECATED.

     We could use G_DISABLE_DEPRECATED only for types, or ditch it entirely.


  2) Stop using -DG_DISABLE_DEPRECATED in the CFLAGS used to build GLib.



I think I like option #1.  It's always seemed weird to me that we deprecate merely by hiding declarations.  It also means that you don't see the new attribute-based warnings if you -DG_DISABLE_DEPRECATED which is a bit lame...
Comment 1 Matthias Clasen 2011-10-17 13:44:20 UTC
sorta like bug 661344 ?
Comment 2 Allison Karlitskaya (desrt) 2011-10-17 14:44:01 UTC
quite a lot like that, indeed

*** This bug has been marked as a duplicate of bug 661344 ***