GNOME Bugzilla – Bug 661944
Message tray goes down on first conversation
Last modified: 2012-04-17 03:35:05 UTC
When you have a new conversation (like in "no previous chat history"), the input box for the notification in the bottom center of the screen goes down on each chat message. To reproduce, get a conversation with someone you never talked to (or clear the chat logs in Empathy and reload the shell), and chat while the notification is in the center of the screen. When the notification goes into the notification area (right), problem's fixed. Attaching a couple screenshots to illustrate.
Created attachment 199154 [details] First reply (half the box is down)
Created attachment 199156 [details] Further chat answers, the box disappears from the screen
*** Bug 672686 has been marked as a duplicate of this bug. ***
Created attachment 210717 [details] [review] telethyClient: stop the chat notification going down on first conversation When getting into a chat through the message tray notification chat client with someone you've never chatted with before, the notification extends downward instead of upward, causing part of the notification to be hidden from view. Expand in updward direction in this case.
Created attachment 210728 [details] [review] telepathyClient: stop the chat notification moving down When responding on a conversation in a chat notification, given there's no prior chat history, the notification moves down below the edge of the screen instead of expanding up, making part of it invisible. Avoid this.
Review of attachment 210728 [details] [review]: It is not obvious why this patch is supposed to work without looking up _update() - it should be clear from the diff and commit message. ::: js/ui/telepathyClient.js @@ +854,2 @@ this._lastGroupActor.add(body, props.childProps); + this._updated(); _updated() is private to MessageTray.Notification
Created attachment 211428 [details] [review] telepathyClient: stop the chat notification moving down When responding on a conversation in a chat notification, given there's no prior chat history, the notification moves down below the edge of the screen instead of expanding up, making part of it invisible. Avoid this by making sure that when the notification should be expanded, it expands.
Created attachment 212004 [details] [review] telepathyClient: call this.updated() when a new message is added to a notification When responding on a conversation in a chat notification, given there's no prior chat history, the notification moves down below the edge of the screen instead of expanding up, making part of it invisible. Avoid this by making sure the notification's position is updated.
Created attachment 212005 [details] [review] telepathyClient: call this.updated() when a new message is added to a notification When responding on a conversation in a chat notification, given there's no prior chat history, the notification moves down below the edge of the screen instead of expanding up, making part of it invisible. Avoid this by making sure the notification's position is updated.
*** Bug 668375 has been marked as a duplicate of this bug. ***
*** Bug 658986 has been marked as a duplicate of this bug. ***
*** Bug 674193 has been marked as a duplicate of this bug. ***
Review of attachment 212005 [details] [review]: Thanks for the update - personally I'd do the renaming in a separate commit, but really up to you whether you want to update the bug or land the patch as-is.
Comment on attachment 212005 [details] [review] telepathyClient: call this.updated() when a new message is added to a notification Thanks for the patch! I think it's good to have the function rename be in the same patch because it is directly related to the change, so I committed it that way, with slight changes to the commit message.