Created attachment 257421 [details] [review]
Ellipsize long names and locations

Attached patch makes entries holding location and printer name to ellipsize if needed.

Review of attachment 257421 [details] [review]:

Screenshot? Wouldn't that potentially lose details that might be added at the end of the string?

Say I have 2 printers of the same type, with long descriptions, wouldn't that cut off the end where the differentiation is?

I'd ellipsise in the middle instead.

Created attachment 268924 [details] [review]
Ellipsize long names and locations

(In reply to comment #2)
> Review of attachment 257421 [details] [review]:
> 
> Screenshot? Wouldn't that potentially lose details that might be added at the
> end of the string?
> 
> Say I have 2 printers of the same type, with long descriptions, wouldn't that
> cut off the end where the differentiation is?
> 
> I'd ellipsise in the middle instead.

I'll attach a screenshot in a minute.

You are right, it is better to ellipsize in the middle for printers.

I've modified also the original code for ellipsizing of printer names in the treeview on the left because it didn't work (it works now, but even if it is set to ellipsize in the middle, it ellipsizes at the end... - probably a bug in gtk+ itself).

Created attachment 268925 [details]
a screenshot comparing different styles of ellipsizing

Review of attachment 268924 [details] [review]:

Looks good.

Comment on attachment 268924 [details] [review]
Ellipsize long names and locations

Thank you for the review. I've pushed the patch to master.