GNOME Bugzilla – Bug 661661
Convert use of deprecated GtkVBox and GtkHBox to GtkBox
Last modified: 2011-11-20 18:05:30 UTC
Cheese uses HBox and VBox in a few places, which have been deprecated: http://developer.gnome.org/gtk3/stable/GtkHBox.html#GtkHBox.description http://developer.gnome.org/gtk3/stable/GtkVBox.html#GtkVBox.description It should be easy to convert these uses to Box (with an associated orientation). Current uses, found with git grep, are: data/cheese-main-window.ui:4: <object class="GtkVBox" id="mainbox_normal"> data/cheese-main-window.ui:16: <object class="GtkHBox" id="content_area"> data/cheese-main-window.ui:18: <object class="GtkVBox" id="view_area"> data/cheese-main-window.ui:35: <object class="GtkHBox" id="butt ons_area"> data/cheese-main-window.ui:37: <object class="GtkHBox" id="mode_toggle_buttons"> data/cheese-main-window.ui:91: <object class="GtkHBox" id="take_action_button_internal_hbox"> data/cheese-main-window.ui:118: <object class="GtkHBox" id="effects_actions_pack"> data/cheese-main-window.ui:138: <object class="GtkHBox" id="effects_toggle_button_internal_hbox"> data/cheese-main-window.ui:180: <object class="GtkHBox" id="leave_fullscreen_button_bin"> data/cheese-main-window.ui:189: <object class="GtkHBox" id="fullscreen_button_internal_hbox"> data/cheese-prefs.ui:54: <object class="GtkVBox" id="dialog-vbox1"> data/cheese-prefs.ui:59: <object class="GtkVBox" id="vbox1"> data/cheese-prefs.ui:69: <object class="GtkHBox" id="hbox2"> data/cheese-prefs.ui:74: <object class="GtkVBox" id="vbox4"> data/cheese-prefs.ui:136: <object class="GtkVBox" id="vbox5"> data/cheese-prefs.ui:195: <object class="GtkHBox" id="hbox1"> data/cheese-prefs.ui:200: <object class="GtkVBox" id="vbox3"> data/cheese-prefs.ui:287: <object class="GtkVBox" id="vbox2"> data/cheese-prefs.ui:367: <object class="GtkHBox" id="hbox4"> data/cheese-prefs.ui:419: <object class="GtkHBox" id="hbox3"> data/cheese-prefs.ui:424: <object class="GtkVBox" id="vbox6"> data/cheese-prefs.ui:469: <object class="GtkVBox" id="vbox7"> src/cheese-window.vala:46: private Gtk.VBox main_vbox; src/cheese-window.vala:52: private Gtk.HBox leave_fullscreen_button_container; src/cheese-window.vala:61: private Gtk.HBox buttons_area; src/cheese-window.vala:1134: main_vbox = (Gtk.VBox)gtk_builder.get_object ("mainbox_normal"); src/cheese-window.vala:1141: leave_fullscreen_button_container = (Gtk.HBox)gtk_builder.get_object ("leave_fullscreen_button_bin"); src/cheese-window.vala:1150: buttons_area = (Gtk.HBox)gtk_builder.get_object ("buttons_area"); src/thumbview/eog-thumb-nav.h:46: GtkHBox base_instance; src/thumbview/eog-thumb-nav.h:53: GtkHBoxClass parent_class; src/vapi/eogthumbnav.vapi:5: public class ThumbNav : Gtk.HBox
Created attachment 201740 [details] [review] Converted deprecated GtkVBox and GtkHBox to GtkBox
Comment on attachment 201740 [details] [review] Converted deprecated GtkVBox and GtkHBox to GtkBox There are some additional uses of VBox and HBox that the simple grep did not find. For example, CheeseAvatarChooser uses gtk_vbox_new(), the EogThumbNav VAPI file still references Gtk.HBox and EogThumbNav still inherits from GtkHBox.
Created attachment 201749 [details] [review] Second patch. Should have converted them all this time.
Created attachment 201751 [details] [review] Stupid mistakes.
Comment on attachment 201751 [details] [review] Stupid mistakes. Squashed and pushed to master as commit 59bdd07f61ae4253f8b7b5430a71ca93aa0e0eff, thanks.
Created attachment 201752 [details] [review] while checking through found something I missed. sorry about the number of patches. Must learn to check my work more.
Comment on attachment 201752 [details] [review] while checking through found something I missed. I already fixed this in the patch that I pushed: http://git.gnome.org/browse/cheese/commit/?id=59bdd07f61ae4253f8b7b5430a71ca93aa0e0eff