GNOME Bugzilla – Bug 661623
gnome-shell-extension-tool crashed with NameError in __main__: name 'extensionjs_path' is not defined
Last modified: 2012-01-03 15:23:56 UTC
This bug has been reported here: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/853882 "gnome-shell-extension-tool is terminated without starting editor. maybe, upstream bug. [how to fix] attached fix patch." Fix patch : https://launchpadlibrarian.net/80329224/gnome-shell-extension-tool-fix.diff
Created attachment 198905 [details] [review] gnome-shell-extension-tool: Fix error after creating extension Whoops, sorry, that's my bug. Here's a proper fix. We require that people submit patches in a 'git format-patch' format with a proper commit message. Additionally, the other change is unrelated.
Review of attachment 198905 [details] [review]: Code looks OK, subject/commit message OTOH is well too generic/non existent.
(In reply to comment #2) > Review of attachment 198905 [details] [review]: > > Code looks OK, subject/commit message OTOH is well too generic/non existent. Suggest a better one?
Created attachment 199137 [details] [review] gnome-shell-extension-tool: Fix error after creating extension Commit 7a8a00c7057d56350d4b5509cefd812a67d4b7d7 cleaned up the code to move all files to a dictionary, which accidentally left an undefined "extensionjs_path" error. Fix that error. Is this a better commit message?
gnome-open is deprecated. can we switch to gvfs-open?
It would be xdg-open if anything, but sure.
Created attachment 199574 [details] [review] gnome-shell-extension-tool: Use xdg-open gnome-open is deprecated Quick fix.
Review of attachment 199137 [details] [review]: Looks good.
Review of attachment 199574 [details] [review]: That too.
Attachment 199137 [details] pushed as 38c768f - gnome-shell-extension-tool: Fix error after creating extension
*** Bug 667187 has been marked as a duplicate of this bug. ***