After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661481 - Delete menu item does not show up translated
Delete menu item does not show up translated
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2011-10-11 18:25 UTC by Gabor Kelemen
Modified: 2011-11-14 07:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Convert the context into a comment (1.17 KB, patch)
2011-10-11 18:32 UTC, Gabor Kelemen 		none Details | Review

Description Gabor Kelemen 2011-10-11 18:25:52 UTC 
The Edit -> Delete menu item does not show up translated. 
This is because a translation context is used incorrectly in the GtkActionEntry definition. The context was added in bug #571359.

If you want to use a translation context, you need to use the g_dpgettext2() call to localize the string:
http://developer.gnome.org/glib/stable/glib-I18N.html#NC-:CAPS
The default function to localize GtkActionEntrys is gettext(), it would be necessary to replace it with g_dpgettext2() using gtk_action_group_set_translate_func().

But using a context here is not needed anymore, as the other occurrence of the _Delete string is not anymore in the source. The simplest solution would be to convert the context to a translator comment - it looks like one anyways.
Comment 1 Gabor Kelemen 2011-10-11 18:32:29 UTC 
Created attachment 198805 [details] [review]
Convert the context into a comment

This would count as a string freeze break, please ask for an approval on gnome-i18n@. You need two, hereby I give one :).
Comment 2 Gabor Kelemen 2011-11-13 12:42:29 UTC 
Ping?
Comment 3 Stef Walter 2011-11-14 07:13:59 UTC 
Thanks. Merged into seahorse master.