After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661475 - string_strip: assertion `self != NULL' failed
string_strip: assertion `self != NULL' failed
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal major
: folks-0.6.4
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-11 16:18 UTC by Guillaume Desmottes
Modified: 2011-10-17 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for caching contacts’ vCards (13.44 KB, patch)
2011-10-16 08:28 UTC, Philip Withnall
accepted-commit_now Details | Review

Description Guillaume Desmottes 2011-10-11 16:18:31 UTC
I get this crash with folks master. I observed until when starting the Shell as well.


(empathy:5170): folks-CRITICAL **: string_strip: assertion `self != NULL' failed

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff3d5a5a6 in gee_iterable_iterator (self=0x0) at iterable.c:78
78		return GEE_ITERABLE_GET_INTERFACE (self)->iterator (self);
(gdb) bt full
  • #0 gee_iterable_iterator
    at iterable.c line 78
  • #1 _folks_individual_update_urls
    at /home/cassidy/dev/folks/folks/individual.vala line 1658
  • #2 _folks_individual_update_fields
    at /home/cassidy/dev/folks/folks/individual.vala line 1022
  • #3 _folks_individual_set_personas
    at /home/cassidy/dev/folks/folks/individual.vala line 2024
  • #4 folks_individual_set_personas
    at /home/cassidy/dev/folks/folks/individual.vala line 741
  • #5 folks_individual_construct
    at /home/cassidy/dev/folks/folks/individual.vala line 934
  • #6 folks_individual_new
    at /home/cassidy/dev/folks/folks/individual.vala line 890
  • #7 _folks_individual_aggregator_add_personas
    at /home/cassidy/dev/folks/folks/individual-aggregator.vala line 922
  • #8 _folks_individual_aggregator_personas_changed_cb
    at /home/cassidy/dev/folks/folks/individual-aggregator.vala line 1184
  • #9 __folks_individual_aggregator_personas_changed_cb_folks_persona_store_personas_changed
    at /home/cassidy/dev/folks/folks/individual-aggregator.vala line 653
  • #10 g_cclosure_user_marshal_VOID__OBJECT_OBJECT_STRING_OBJECT_ENUM
    at /home/cassidy/dev/folks/folks/persona-store.vala line 281
  • #11 g_closure_invoke
    at gclosure.c line 774
  • #12 signal_emit_unlocked_R
    at gsignal.c line 3272
  • #13 g_signal_emit_valist
    at gsignal.c line 3003
  • #14 g_signal_emit_by_name
    at gsignal.c line 3097
  • #15 _folks_persona_store_emit_personas_changed
    at /home/cassidy/dev/folks/folks/persona-store.vala line 384
  • #16 _tpf_persona_store_load_cache_co
    at /home/cassidy/dev/folks/backends/telepathy/lib/tpf-persona-store.vala line 1039
  • #17 _tpf_persona_store_load_cache_ready
    at /home/cassidy/dev/folks/backends/telepathy/lib/tpf-persona-store.vala line 1016
  • #18 g_simple_async_result_complete
    at gsimpleasyncresult.c line 749
  • #19 folks_object_cache_load_objects_co
    at /home/cassidy/dev/folks/folks/object-cache.vala line 265
  • #20 folks_object_cache_load_objects_ready
    at /home/cassidy/dev/folks/folks/object-cache.vala line 162
  • #21 g_simple_async_result_complete
    at gsimpleasyncresult.c line 749
  • #22 load_contents_close_callback
    at gfile.c line 6264
  • #23 async_ready_close_callback_wrapper
    at ginputstream.c line 484
  • #24 g_simple_async_result_complete
    at gsimpleasyncresult.c line 749
  • #25 complete_in_idle_cb_for_thread
    at gsimpleasyncresult.c line 817
  • #26 g_idle_dispatch
    at gmain.c line 4801
  • #27 g_main_dispatch
    at gmain.c line 2441
  • #28 g_main_context_dispatch
    at gmain.c line 3011
  • #29 g_main_context_iterate
    at gmain.c line 3089
  • #30 g_main_loop_run
    at gmain.c line 3297
  • #31 gtk_main
    at gtkmain.c line 1362
  • #32 gtk_application_run_mainloop
    at gtkapplication.c line 115
  • #33 g_application_run
    at gapplication.c line 1323
  • #34 main
    at empathy.c line 841

Comment 1 Philip Withnall 2011-10-11 16:57:17 UTC
Looks like we forgot to implement the vCard stuff in Tpf.PersonaStoreCache, and so the set of URIs is getting set to NULL when loading a Telepathy persona from the cache.
Comment 2 Travis Reitter 2011-10-11 20:37:55 UTC
Setting this as the sole requirement before 0.6.4 (which will be our last per-release milestone).
Comment 3 Philip Withnall 2011-10-16 08:28:22 UTC
Created attachment 199107 [details] [review]
Add support for caching contacts’ vCards

https://www.gitorious.org/folks/folks/commits/661475-tp-vcard-caching
Comment 4 Travis Reitter 2011-10-17 18:38:06 UTC
Review of attachment 199107 [details] [review]:

Looks good to me - I'll merge.
Comment 5 Travis Reitter 2011-10-17 18:45:19 UTC
commit 2a88b99a143a2d38253dfe92ce0140f33b453a7d
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sun Oct 16 09:24:57 2011 +0100

    telepathy: Add support for caching vCard parameters for contacts
    
    Add birthday, full name, e-mail address, phone number and URL support to the
    Telepathy object cache so that contacts’ vCards are correctly stored when
    the cache is updated.
    
    Closes: bgo#661475

 NEWS                                               |    1 +
 .../telepathy/lib/tpf-persona-store-cache.vala     |  191 +++++++++++++++++++-
 backends/telepathy/lib/tpf-persona.vala            |   34 ++++-
 3 files changed, 222 insertions(+), 4 deletions(-)

commit 5691fe6dcb5f8dac0a031c52994abbb6e1ad7d4d
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sun Oct 16 09:23:29 2011 +0100

    core: Add support for object version migration in object cache files
    
    Add the ability for the variant type used in object cache files to vary with
    the cache file version, and for object cache implementations to claim they
    don't support given versions.
    
    Helps: bgo#661475

 .../telepathy/lib/tpf-persona-store-cache.vala     |   42 +++++++++++++-------
 folks/object-cache.vala                            |   40 ++++++++++++++++---
 2 files changed, 62 insertions(+), 20 deletions(-)

commit a9b8ec19dfb6c9f61f9f85d6ebfcf117bdc575a4
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sun Oct 16 09:19:29 2011 +0100

    telepathy: Fix mixed-assignments-and-declarations warning in test library

 .../telepathy/contactlist/contact-list-manager.c   |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)