GNOME Bugzilla – Bug 661225
Don't mark text as URLs that are unsupported
Last modified: 2013-04-29 15:37:50 UTC
Created attachment 198567 [details] screenshot If we identify something as a URL we should at least try to load it. In the attached screenshot you can see that we identify the string as a URL and underline it and make it clickable. However, when I click on it nothing happens. This confused me. It seems like this is due to: gvfs-open: okhttp://www.tripadvisor.com/ShowUserReviews-....: error opening location: The specified location is not supported Really two things. We should try to properly identify the real URL here. Then we should never identify and mark things as URLs that aren't supported and can't load at all.
(In reply to comment #0) > Really two things. We should try to properly identify the real URL here. That's bug 649994. > we should never identify and mark things as URLs that aren't supported and > can't load at all. Let's keep the bug for this issue - renaming appropriately.
Created attachment 241525 [details] [review] Only recognize common url schemes in notification messages Before the fix, the message tray highlighted all urls containing "://", even invalid ones. This change fixes this by have the message tray highlight only the urls with http, https, ftp schemes. Credit goes to: Phuong Vu, Liye Fu, Monica Chelliah, Owen Taylor
Monica, Phuong, Liye, Sorry for taking a long time to get back to this. I've given the patch another look-over, and retested it, and it still seems right to me, so I've pushed the fix to the master gnome-shell repository: https://git.gnome.org/browse/gnome-shell/commit/?id=608818fa9f3f748d92e6881ab3d8f3c093e197cd While a more complex solution that queried the possible supported URL schemes might be possible, I don't see any immediate need for it, and I'm going to close bug as fixed. Thanks for the contribution! - Owen Attachment 241525 [details] pushed as 608818f - Only recognize common url schemes in notification messages