After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661122 - videotestsrc does not build on Solaris
videotestsrc does not build on Solaris
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.35
Other Solaris
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-06 20:16 UTC by Brian Cameron
Modified: 2011-10-10 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing issue (496 bytes, patch)
2011-10-06 20:16 UTC, Brian Cameron 		committed Details | Review
patch fixing gst-plugins-good (1.50 KB, patch)
2011-10-06 20:18 UTC, Brian Cameron 		needs-work Details | Review

Description Brian Cameron 2011-10-06 20:16:14 UTC 
Created attachment 198471 [details] [review]
patch fixing issue

The videotestsrc plugin in gst-plugins-base 0.10.35 does not compile on Solaris
because the Solaris linker requires that the glib libraries be included on the LDADD line as shown in the attached patch.  Can this go upstream?
Comment 1 Brian Cameron 2011-10-06 20:18:49 UTC 
Created attachment 198472 [details] [review]
patch fixing gst-plugins-good
Comment 2 David Schleef 2011-10-08 19:56:47 UTC 
Approve the videotestsrc patch, please push.

In -good, please change it to how gst/videomixer/Makefile.am pulls in gstvideo, and then push that one.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2011-10-10 11:15:02 UTC 
Comment on attachment 198471 [details] [review]
patch fixing issue

commit ded27cc61a7218fa4c26d75c129a46c01ccb7153
Author: Brian Cameron <brian.cameron@oracle.com>
Date:   Mon Oct 10 13:11:59 2011 +0200

    videotestsrc: fix LDADD missing GST_LIBS
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2011-10-10 11:20:52 UTC 
Push this for gst-plugins-good. Please use git formatted patches in the future and file separate bugs for separate modules.

commit 4b06e3095a2aac5b81f931677ce539d715139989
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Mon Oct 10 13:20:04 2011 +0200

    tests: add missing PLUGIN_ASE_LIBS to LDADD
Comment 5 Brian Cameron 2011-10-10 15:46:06 UTC 
Sorry, thanks for fixing this!