After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660894 - Thinko in computation of fallback size for icons
Thinko in computation of fallback size for icons
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-04 15:59 UTC by Federico Mena Quintero
Modified: 2011-10-04 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix confusion in the fallback size for icons (892 bytes, patch)
2011-10-04 15:59 UTC, Federico Mena Quintero 		accepted-commit_now Details | Review

Description Federico Mena Quintero 2011-10-04 15:59:05 UTC 
When reading the code, I caught a mistake in the fallback size that is returned for icons (in pixels).  NAUTILUS_ZOOM_LEVEL_SIZE is part of a plain enum; what we want is the NAUTILUS_ICON_SIZE_STANDARD macro, which specifies a pixel size.  Patch attached.
Comment 1 Federico Mena Quintero 2011-10-04 15:59:31 UTC 
Created attachment 198230 [details] [review]
Fix confusion in the fallback size for icons

Just caught this when reading the code...
Comment 2 Cosimo Cecchi 2011-10-04 16:15:40 UTC 
Review of attachment 198230 [details] [review]:

Looks good, thanks.
Comment 3 Federico Mena Quintero 2011-10-04 18:08:12 UTC 
Pushed to master; thanks!