GNOME Bugzilla – Bug 660838
issues moving windows from one workspace to another
Last modified: 2011-10-04 18:43:54 UTC
I'm using a 2 screen setup where the screen are arranged vertically, primary on top, secondary at the bottom. On the primary screen, if I go in overview mode, and drag and drop a window down to move it to another workspace, when I get to the part of the screen triggering the "scroll to next workspace", it moves down by 2 workspaces instead of 1. I've verified that when I turn off the secondary screen, this behaviour doesn't happen.
Created attachment 198169 [details] [review] workspaces-view: Remove window dnd between workspaces When workspace "previews" in the overview were just tiny gray rectangles, it made sense to provide a way to move windows directly between workspaces (by switching workspaces when dragging a window to the corresponding screen edge). As the overview has evolved however, the workspace switcher provides a good and intuitive drop target already, so the alternative provided by the screen edges is no longer necessary. As it also conflicts with moving windows between monitors when using a vertical layout, just remove it. (Alternative 1 - remove the ability to move windows directly between workspaces)
Created attachment 198170 [details] [review] workspaces-view: Fix window DND for vertically stacked monitors When dragging windows directly to another workspace, we have some safeguards in place to avoid switching more than one workspace at once. However, the code assumes that the pointer can not "overshoot" the area of the primary monitor, which is an incorrect assumption when using a vertical layout in multi-monitor setups. Fix the code to handle this case correctly. (Alternative 2 - fix this particular case to only switch one workspace at once; I don't have a multimonitor setup to test right now, so testing is appreciated. It does not remove the ambiguity between "move window to another workspace" and "move window to another monitor" which exists for vertically stacked monitors though)
Review of attachment 198169 [details] [review]: Makes sense to me and code looks good (just an unrelated change slipped in) ... maybe we should get some feedback from design here otherwise good. ::: js/ui/userMenu.js @@ +350,3 @@ _sessionStatusChanged: function(sessionPresence, sessionStatus) { + if (this._sessionPresenceRestored) + this._settings.set_int('saved-session-presence', sessionStatus); Unrelated.
(In reply to comment #2) > Created an attachment (id=198170) [details] [review] > workspaces-view: Fix window DND for vertically stacked monitors > > (Alternative 2 - fix this particular case to only switch one workspace at once; > I don't have a multimonitor setup to test right now, so testing is appreciated. I just tested this patch on a vertical stack setup and it's working for me. > It does not remove the ambiguity between "move window to another workspace" and > "move window to another monitor" which exists for vertically stacked monitors > though) Indeed, but I don't think it's too bad, at least it's fine with me.
(In reply to comment #4) > (In reply to comment #2) > > It does not remove the ambiguity between "move window to another workspace" and > > "move window to another monitor" which exists for vertically stacked monitors > > though) > > Indeed, but I don't think it's too bad, at least it's fine with me. Liar - if it was fine, you wouldn't have filed bug 660835 ;-)
(In reply to comment #5) > (In reply to comment #4) > > > > Indeed, but I don't think it's too bad, at least it's fine with me. > > Liar - if it was fine, you wouldn't have filed bug 660835 ;-) Ah, I was specifically talking about moving from primary to secondary/moving from workspace to workspace, which is when this bug occurred. Moving from secondary to primary (bug #660835) could indeed be improved :)
Comment on attachment 198169 [details] [review] workspaces-view: Remove window dnd between workspaces Attachment 198169 [details] pushed as 28c3e06 - workspaces-view: Remove window dnd between workspaces (In reply to comment #3) > maybe we should get some feedback from design here otherwise good. Yeah: <mccann> oh <mccann> didn't know we had that feature <fmuellner> well, you designed it waaaay back :-) <mccann> fmuellner: oh yeah horizontally <mccann> i'm fine with just using the drop targets for organizing windows <mccann> is that what you mean? <fmuellner> drop targets == workspace previews? <mccann> yeah <fmuellner> yeah, that's what I mean > ::: js/ui/userMenu.js > Unrelated. Gah, damn you git-commit -a! Removed.
(In reply to comment #6) > Ah, I was specifically talking about moving from primary to secondary/moving > from workspace to workspace, which is when this bug occurred. Moving from > secondary to primary (bug #660835) could indeed be improved :) Mmh, I'd expect a conflict in either case (depending on the current workspace). Anyway, we killed the feature, so that's a two-in-one bug fix ;-)