GNOME Bugzilla – Bug 660806
No Caps Lock warning
Last modified: 2011-10-17 21:36:09 UTC
There is no warning for caps lock when typing in your password, which was a very useful figured in previous versions.
We probably want this in all password fields, which means this should go in St I guess.
(In reply to comment #1) > We probably want this in all password fields, which means this should go in St > I guess. With Florian's work on ShellEntry, it should be fairly easy to do as a secondary icon.
*** Bug 661938 has been marked as a duplicate of this bug. ***
Created attachment 199263 [details] [review] st-entry: Display a capslock warning in password entries Implement the GtkEntry behavior of showing a warning icon when capslock is turned on while entering hidden text.
Created attachment 199264 [details] [review] css: Style the capslock warning in password entries
Review of attachment 199263 [details] [review]: ::: src/st/st-entry.c @@ +499,3 @@ + + keymap = gdk_keymap_get_for_display (gdk_display_get_default ()); + g_signal_handlers_disconnect_by_func (keymap, keymap_state_changed, entry); If I'm reading this right, this has a "glitch": 1. Focus field. 2. Turn caps lock on. 3. Blur field. 4. Turn caps lock off. Just calling remove_capslock_feedback() here should fix that.
Review of attachment 199264 [details] [review]: LGTM.
This is pretty much a verbatim copy of the code in GtkEntry, with two exceptions: - only warn on capslock (Gtk also warns on numlock and differentiates using a tooltip - we don't do tooltips in shell) - no "caps-lock-warning" property to disable the behavior (we can add this later should we need it)
Created attachment 199269 [details] [review] st-entry: Display a capslock warning in password entries (In reply to comment #6) > If I'm reading this right, this has a "glitch": > > 1. Focus field. > 2. Turn caps lock on. > 3. Blur field. > 4. Turn caps lock off. With "blur" you mean "show text"? If so, attached patch should fix it ...
Created attachment 199272 [details] [review] st-entry: Display a capslock warning in password entries OK, so apparently that was not what was meant by "blur" - fixed after clarification on IRC.
Review of attachment 199272 [details] [review]: Looks good.
Attachment 199264 [details] pushed as 0eab448 - css: Style the capslock warning in password entries Attachment 199272 [details] pushed as a26a77f - st-entry: Display a capslock warning in password entries
hey thanks Florian!